Issue metadata
Sign in to add a comment
|
[BGPT] No console output from AnimationWorklets |
||||||||||||||||||||||
Issue descriptionWhen run with blink-gen-property-trees Tests that fail as a result: virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html
,
Jul 24
This looks like a duplicate of 855688 - there is console output, but the animation worklet is not starting.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e33e9d2a04d284b061e024103dd36ba07daa32d commit 8e33e9d2a04d284b061e024103dd36ba07daa32d Author: Peter Mayo <petermayo@chromium.org> Date: Thu Aug 09 14:34:12 2018 [BGPT] Allow new optimizations in layout tests With --enable-blink-gen-property-trees we don't repaint invisible nodes on the compositor, so we don't need to animate it, and so the console output is not present, nor are other animated changes. This is arguably better, but was being tested for naively. Bug:855691 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1 Reviewed-on: https://chromium-review.googlesource.com/1162075 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> [modify] https://crrev.com/8e33e9d2a04d284b061e024103dd36ba07daa32d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/8e33e9d2a04d284b061e024103dd36ba07daa32d/third_party/WebKit/LayoutTests/virtual/threaded/animations/compositor-independent-transform-cancel.html [modify] https://crrev.com/8e33e9d2a04d284b061e024103dd36ba07daa32d/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html [modify] https://crrev.com/8e33e9d2a04d284b061e024103dd36ba07daa32d/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html [modify] https://crrev.com/8e33e9d2a04d284b061e024103dd36ba07daa32d/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bad2ad666be598479b7b9fe8449416f37d2444b5 commit bad2ad666be598479b7b9fe8449416f37d2444b5 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Thu Aug 09 19:17:36 2018 Revert "[BGPT] Allow new optimizations in layout tests" This reverts commit 8e33e9d2a04d284b061e024103dd36ba07daa32d. Reason for revert: Due to Gerrit outage http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience. Original change's description: > [BGPT] Allow new optimizations in layout tests > > With --enable-blink-gen-property-trees we don't repaint invisible nodes > on the compositor, so we don't need to animate it, and so the console > output is not present, nor are other animated changes. This is arguably > better, but was being tested for naively. > > Bug:855691 > Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1 > Reviewed-on: https://chromium-review.googlesource.com/1162075 > Commit-Queue: Robert Flack <flackr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> TBR=petermayo@chromium.org,flackr@chromium.org,pdr@chromium.org Change-Id: I648e25fd445fe9d2dc8f8f4056b7fd6d80abcdf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855691 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1169791 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/third_party/WebKit/LayoutTests/virtual/threaded/animations/compositor-independent-transform-cancel.html [modify] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html [modify] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html [modify] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html
,
Aug 13
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897 commit f3263d96a2fd7568f410fbebc0ed7d6ea82e2897 Author: Peter Mayo <petermayo@chromium.org> Date: Mon Aug 13 15:50:01 2018 [BGPT] Allow new optimizations in layout tests With --enable-blink-gen-property-trees we don't repaint invisible nodes on the compositor, so we don't need to animate it, and so the console output is not present, nor are other animated changes. This is arguably better, but was being tested for naively. This is a reland of 8e33e9d2a04d284b061e024103dd36ba07daa32d > Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1 > Reviewed-on: https://chromium-review.googlesource.com/1162075 > Commit-Queue: Robert Flack <flackr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> Bug: 855691 Change-Id: Idea876e956be546c1b35a0646de9260b9450592e Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1169932 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582593} [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-filter-webkit-filter.html [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/virtual/threaded/animations/compositor-independent-transform-cancel.html [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html [modify] https://crrev.com/f3263d96a2fd7568f410fbebc0ed7d6ea82e2897/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by petermayo@chromium.org
, Jun 22 2018