[BGPT] Element animations not starting |
|||
Issue description
With enable-blink-gen-property-trees thee are some layout tests that fail by not starting element animations:
transitions/opacity-transform-transitions-inside-iframe.html
virtual/threaded/transitions/opacity-transform-transitions-inside-iframe.html
transitions/transition-end-event-destroy-iframe.html
virtual/threaded/transitions/transition-end-event-destroy-iframe.html
In the first one we can examine the following:
background.animate({opacity: ['1', '0']}, 10000)
and observe that it never begins under enable-blink-gen-property-trees, whereas it does usually.
in the second, adding a transform style is not begun.
box1.style.transform = 'translate(100px, 0)';
,
Jul 24
This appears to be because there is no layer tree host associated with the layers in the layer list, therefore we do not register the element ID on an animation host, and the animations don't start.
,
Jul 24
,
Aug 13
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22c7c1f9f14749cda30b19f3fe1ae08903885b22 commit 22c7c1f9f14749cda30b19f3fe1ae08903885b22 Author: Peter Mayo <petermayo@chromium.org> Date: Thu Aug 30 14:15:37 2018 [BGPT] Update animations in subframes In blink-gen-property-trees mode we were only calling update animations on the top level document, so animation content in subframes (like iframes) was not being processed. This adds a simpler reproduction case to point at this behavior too. R: pdr@chromium.org Bug: 855688 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic4707bda5fa67cd5bfd2894040d71ef34d5b0c2c Reviewed-on: https://chromium-review.googlesource.com/1195887 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587559} [modify] https://crrev.com/22c7c1f9f14749cda30b19f3fe1ae08903885b22/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/22c7c1f9f14749cda30b19f3fe1ae08903885b22/third_party/blink/renderer/core/animation/document_animations.cc [modify] https://crrev.com/22c7c1f9f14749cda30b19f3fe1ae08903885b22/third_party/blink/renderer/core/animation/document_animations.h [modify] https://crrev.com/22c7c1f9f14749cda30b19f3fe1ae08903885b22/third_party/blink/renderer/core/frame/local_frame_view.cc
,
Sep 14
Is this fixed?
,
Sep 14
Yes, I believe this looks good now! :-) |
|||
►
Sign in to add a comment |
|||
Comment 1 by petermayo@chromium.org
, Jun 22 2018Labels: Hotlist-Experimental