Unable to mute site while in PiP mode. |
||
Issue descriptionVersion 69.0.3470.0 (Developer Build) unknown (64-bit) Linux While there is an active PiP window, I am unable to mute the site from the tab context menu. Repro: 1. On tip of tree, enable: - enable-surfaces-for-videos - enable-picture-in-picture 2. Go to: https://www.w3.org/2010/05/video/mediaevents.html [ Able to mute the site from the tab context menu. ] 3. Start playback, enter Picture-in-Picture. [ Unable to mute the site from the tab context menu. It appears 'disabled' but the menu item still exists. ] 4. Exit Picture-in-Picture. [ Able to mute the site from the tab context menu. ] steimel: any thoughts?
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c97e58e6acda53f36a87adbad5578d3ae3e91c5 commit 9c97e58e6acda53f36a87adbad5578d3ae3e91c5 Author: Tommy Steimel <steimel@chromium.org> Date: Mon Jun 25 23:23:04 2018 [Site Muting] Allow user to mute site while in PiP mode This CL updates the CanToggleAudioMute logic to always return true when the user is in PiP mode. Bug: 855686 Change-Id: Iea22547c8c4b50c859f84bf7277d08cdd736309b Reviewed-on: https://chromium-review.googlesource.com/1112697 Reviewed-by: apacible <apacible@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570232} [modify] https://crrev.com/9c97e58e6acda53f36a87adbad5578d3ae3e91c5/chrome/browser/ui/tabs/tab_utils.cc
,
Jun 25 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Jun 22 2018