New issue
Advanced search Search tips

Issue 855672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add flag to disable offline demo mode

Project Member Reported by agawronska@chromium.org, Jun 22 2018

Issue description

We need a flag to disable offline demo mode separately from online demo mode.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc

commit 8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc
Author: Aga Wronska <agawronska@chromium.org>
Date: Mon Jul 09 23:09:55 2018

Add kEnableOfflineDemoModeFlag.

This flag guards entry point to setup device in offline demo mode.
It needs to be used in combination with kEnableDemoMode flag to take
effect. It allows to enable/disable offline demo mode when demo mode
feature is enabled.

Bug:  855672 
Test: Run browser tests DemoSetpTest, DemoSetupOfflineDisabledTest + manually
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1383d664a56cb41e2aabe8e57fbe2d684048f463
Reviewed-on: https://chromium-review.googlesource.com/1112901
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573507}
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chromeos/chromeos_switches.cc
[modify] https://crrev.com/8b0ab5b3c12a4a7d21b939d2800d6e518e9646dc/chromeos/chromeos_switches.h

Status: Fixed (was: Started)

Sign in to add a comment