New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855670 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Ominbox is "stuck" with incorrect URL and performs overscroll actions when tapped.

Project Member Reported by michaeldo@chromium.org, Jun 22 2018

Issue description

Chrome Version: 69.0.3466.0
OS: iOS

What steps will reproduce the problem?
Full steps unknown, I believe something like this is what triggered it:
(1) On NTP, tap omnibox.
(2) Omnibox becomes broken.


What is the expected result?
Omnibox should function correctly.

What happens instead?
Omnibox can not be focused and remains in this broken state until app relaunch. When tapping on the omnibox, the overscroll actions at that location are performed. (For example, tapping the middle of the ombinbox performs a refresh.)


 
broken_omnibox.JPG
240 KB View Download
wrong_url.JPG
369 KB View Download
text_field_covered.JPG
425 KB View Download
Labels: ReleaseBlock-Stable M-69
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Stepan, do you know if there are any scenarios in which the location bar becomes disconnected from the WebStateObserver that updates the visible URL?
Cc: stkhapugin@chromium.org justincohen@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>NewTabPage UI>Browser>Toolbar
Labels: MS-Adaptive-Toolbar Proj-UIRefresh
Owner: gambard@chromium.org
Seems like a second copy of toolbar stuck?
Cc: linds...@chromium.org
Labels: Q2
I think this is because the overscroll action is not ended correctly and staying at 1pt of completion. So the screenshot of the toolbar is shown (and never updated when navigating). I wasn't able to reproduce it.
kkhorimoto@: do you have any idea how this could happen?
lindsayw@: Is it possible to have some test support to try to reproduce this?
It might actually be linked to issue 853566 but I wasn't able to reproduce it neither.
Cc: srikanthg@chromium.org
We'll check around to see if we can find anything reproducible.
michaeldo@ What device and os version are you running, so that I can try checking with same configs. I tried on few iPhones with iOS11 and iOS12 but so far no luck.
Do you know if you have slim-navigation-manager enabled on your device.

I am able to reproduce your screenshot#3 (text_filed_covered.JPG) using the tip form comment#3. Here are the step for that.

Launch Chrome
Navigate to any webpage.
Initial overscroll action by swiping down the content area (Hold finger down, don't release)
Tap on the Search icon from bottom toolbar.

This will result in what attached in screenshot#3.

https://drive.google.com/file/d/1gIY6XTxpegaTz3v4KZTzkuygY8p1KSjU/view
I'm on an iPhone 7, iOS 11.3 and I have the following flags force enabled:
#tab_switcher_presents_bvc
#slim-navigation-manager
#wk-http-system-cookie-store
#ui-refresh-phase-1
Also note that I have more than 100 open tabs in case that is relevant.

I wish I had better steps, but I encountered this during "normal use" so I don't know the precise steps that caused it. I don't use the search icon, but I do use the overscroll actions for new tab and the "New Tab" in the menu. (Of course reproducing with the search icon is possibly triggering the same problem, but I wasn't doing anything with multiple fingers when I reproduced.)

Thank you srikanthg@! The steps/video appear to get the omnibox into a similar state.
gambard: I'm not really sure what situations would cause the overscroll animation to remain incomplete.  Maybe the steps in comment #6 might shed some light as to how that state may occur?
Labels: -Pri-2 Pri-1

Comment 10 by marq@chromium.org, Jun 26 2018

Labels: -ReleaseBlock-Stable
Labels: zine-triaged
When I did some work making BCVC fullscreen I hit something similar: the overscroll action is missing 1pt to get to its initial scroll offset (which is the point where it is disabled). So during this, it is displaying the screenshot of the toolbar.
However I hit this during an experimentation behind a flag so I don't think it is related.

Maybe the scroll view used by the overscroll controller isn't reporting its scroll offset correctly?
This issue is reproducible with the following steps:

App Version: 69.0.3489.0 canary
Devices: iPhone 6 Plus, iPhone 6, iPhone X
iOS Versions: 10.3.3, 11.3, 11.4.1

1. Launch iOS Chrome
2. Open 2 or 3 tabs (ex. tab1, tab2, tab3) and navigate to various URLs
3. Initiate overscroll action (at tab3) by swiping down the content area thrice 
4. Change the device orientation to landscape
5. Close tab3 

Observed results: 
At Step 4: Omnibox will be in broken state
At Step 5: Omnibox gets stuck with incorrect URL

Video: 
https://drive.google.com/open?id=1Wafj-YtkLPXaip3ZdCYEgchFjREUZtQS

Components: UI>Browser>PullToAction
Cc: subhashi...@chromium.org
Wow, that's super nice! I think this is exactly the issue we were looking for. Thanks!

However, I was only able to reproduce 1 out 20-30 tries. How often are you able to reproduce?
Does it reproduce on any webpage? Do you do anything particular for swiping the content?
I could consistently(i.e. 5/5 times) reproduce the issue with the steps mentioned in comment#13. 

Yes, it reproducible on any webpage.
I am still not able to reproduce but I am able to have stuck on landscape. I will submit a fix based on that.
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5daaedabb25ca26896347870ae7d05b6d33191ed

commit 5daaedabb25ca26896347870ae7d05b6d33191ed
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jul 13 07:10:34 2018

Modify overscroll only when dragging scroll view

This CL modifies the overscroll actions controller to update its view
when the user starts pulling only when the user is actually dragging the
scroll view. If it happens on automatic scrolling, do nothing to avoid
adding the overscroll view again.

Bug:  855670 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If5047354ab5b02c4c8fb80166d93a49a1e3e6059
Reviewed-on: https://chromium-review.googlesource.com/1134999
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574849}
[modify] https://crrev.com/5daaedabb25ca26896347870ae7d05b6d33191ed/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

Status: Fixed (was: Assigned)
I have landed a possible fix. It should now be in Canary. Can you verify that you cannot reproduce the issue?
Thanks!
Status: Verified (was: Fixed)
Verified in:

App Version: 69.0.3494.0 canary
Devices: iPhone 6 Plus, iPhone X
iOS Versions: 10.3.3, 11.4.1 beta 5

Followed the steps mentioned in Comment#13 and issue is not reproducible. Omnibox doesn't get stuck in landscape.

Sign in to add a comment