QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest failing with UAv2 |
||
Issue descriptionThis repros only with --enable-features=UserActivationV2. Repro steps: ./out/Default/browser_tests --gtest_filter=QUnitBrowserTestRunner.* --enable-features=UserActivationV2 The test times out at ExecuteScriptAndExtractString. Here is a dump of console output with a stack trace: IMPORTANT DEBUGGING NOTE: each test is run inside its own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with either --single_process (to run the test in one launcher/browser process) or --single-process (to do the above, and also run Chrome in single-process mode). Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from QUnitBrowserTestRunner, where TypeParam = [ RUN ] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest [246755:246755:0622/132920.526999:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [246805:246805:0622/132921.389069:INFO:GrGLInterface.cpp(542)] ../../third_party/skia/src/gpu/gl/GrGLInterface.cpp:542 GrGLInterface::validate() failed. [246755:246755:0622/132922.255342:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [246755:246755:0622/132923.246872:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 frame_=0x3ef866d01d00 [246755:246755:0622/132926.240326:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [246755:246755:0622/132927.422449:INFO:CONSOLE(95)] "Error parsing JSON:", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/butter_bar.js (95) Still waiting for the following processes to finish: ./out_linux/Default/browser_tests --enable-features=UserActivationV2 --gtest_also_run_disabled_tests --gtest_filter=QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.k8LB7s/resultsIqLVB9/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.k8LB7s/daGXJmO [246755:246755:0622/132934.646749:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [246755:246755:0622/132934.897200:INFO:CONSOLE(177)] "Missing PNaCl plugin last error string.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/chromoting_event.js (177) [246755:246755:0622/132935.905165:INFO:CONSOLE(643)] "Connection established.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (643) [246755:246755:0622/132935.906783:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) [246755:246755:0622/132936.900147:INFO:CONSOLE(643)] "Connection established.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (643) [246755:246755:0622/132936.901166:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) [246755:246755:0622/132936.907125:INFO:CONSOLE(430)] "[2018-06-22T17:29:36.904Z]Sending Iq: sample message", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (430) [246755:246755:0622/132937.897398:INFO:CONSOLE(643)] "Connection established.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (643) [246755:246755:0622/132937.898338:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) [246755:246755:0622/132937.902673:INFO:CONSOLE(463)] "[2018-06-22T17:29:37.900Z]Receiving Iq: <iq>sample</iq>", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (463) [246755:246755:0622/132938.896020:INFO:CONSOLE(643)] "Connection established.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (643) [246755:246755:0622/132938.896972:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) [246755:246755:0622/132938.901357:INFO:CONSOLE(430)] "[2018-06-22T17:29:38.898Z]Sending Iq: <cli:iq to="fake_jid" type="set" id="session-terminate" xmlns:cli="jabber:client"><jingle xmlns="urn:xmpp:jingle:1" action="session-terminate" sid=""><reason><success/></reason></jingle></cli:iq>", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (430) [246755:246755:0622/132938.902272:INFO:CONSOLE(664)] "Connection closed.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (664) [246755:246755:0622/132939.895953:INFO:CONSOLE(643)] "Connection established.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (643) [246755:246755:0622/132939.896894:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) [246755:246755:0622/132939.900422:INFO:CONSOLE(430)] "[2018-06-22T17:29:39.898Z]Sending Iq: <cli:iq to="fake_jid" type="set" id="session-terminate" xmlns:cli="jabber:client"><jingle xmlns="urn:xmpp:jingle:1" action="session-terminate" sid=""><reason><success/></reason></jingle></cli:iq>", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (430) [246755:246755:0622/132939.901333:INFO:CONSOLE(677)] "Connection dropped: ERROR_P2P_FAILURE", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (677) [246755:246755:0622/132940.899685:INFO:CONSOLE(671)] "Connection failed: ERROR_INVALID_ACCESS_CODE", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (671) [246755:246755:0622/132940.900654:INFO:CONSOLE(651)] "Connecting as email", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/client_session.js (651) Still waiting for the following processes to finish: ./out_linux/Default/browser_tests --enable-features=UserActivationV2 --gtest_also_run_disabled_tests --gtest_filter=QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.k8LB7s/resultsIqLVB9/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.k8LB7s/daGXJmO [246755:246755:0622/132954.898184:INFO:CONSOLE(155)] "DNS blackhole check succeeded.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/dns_blackhole_checker.js (155) [246755:246755:0622/132955.902908:INFO:CONSOLE(155)] "DNS blackhole check succeeded.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/dns_blackhole_checker.js (155) [246755:246755:0622/132956.898667:INFO:CONSOLE(155)] "DNS blackhole check succeeded.", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/dns_blackhole_checker.js (155) [246755:246755:0622/132957.394608:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [246755:246755:0622/132957.896254:INFO:CONSOLE(162)] "DNS blackhole check failed: 400 Bad Request. Response URL: undefined. Response Text: ", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/dns_blackhole_checker.js (162) [246755:246755:0622/132958.902242:INFO:CONSOLE(162)] "DNS blackhole check failed: 400 Bad Request. Response URL: undefined. Response Text: ", source: file:///usr/local/google/home/mustaq/Work/chromium/src/out_linux/Default/remoting/unittests/dns_blackhole_checker.js (162) Still waiting for the following processes to finish: ./out_linux/Default/browser_tests --enable-features=UserActivationV2 --gtest_also_run_disabled_tests --gtest_filter=QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.k8LB7s/resultsIqLVB9/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.k8LB7s/daGXJmO BrowserTestBase received signal: Terminated. Backtrace: #0 0x7fcde43a8b7d base::debug::StackTrace::StackTrace() #1 0x7fcde40f14bc base::debug::StackTrace::StackTrace() #2 0x0000072d1ce4 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fcdc1035030 <unknown> #4 0x7fcdc10e163d __poll #5 0x7fcdc495c0b9 <unknown> #6 0x7fcdc495c1cc g_main_context_iteration #7 0x7fcde418de9f base::MessagePumpGlib::Run() #8 0x7fcde41891bb base::MessageLoop::Run() #9 0x7fcde42327cd base::RunLoop::Run() #10 0x0000072dc8ec content::DOMMessageQueue::WaitForMessage() #11 0x0000072d8572 content::(anonymous namespace)::ExecuteScriptHelper() #12 0x0000072d746e content::ExecuteScriptAndExtractString() #13 0x000003f0cd4e QUnitBrowserTestRunner::QUnitStart() #14 0x000003f0e101 QUnitBrowserTestRunner::RunTest() #15 0x000003f27c25 remoting::QUnitBrowserTestRunner_Remoting_Webapp_Js_Unittest_Test::RunTestOnMainThread() #16 0x0000072d0853 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #17 0x000001f24d3d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #18 0x000001f24c84 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #19 0x000001f24c35 _ZN4base8internal7InvokerINS0_9BindStateIM25RenderViewContextMenuBaseFvvEJNS0_17UnretainedWrapperI21RenderViewContextMenuEEEEEFvvEE7RunImplIS5_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #20 0x00000201fffc _ZN4base8internal7InvokerINS0_9BindStateIMN13browsing_data19BrowsingDataCounterEFvvEJNS0_17UnretainedWrapperI12CacheCounterEEEEEFvvEE3RunEPNS0_13BindStateBaseE #21 0x000001f1684d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #22 0x00000638509f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #23 0x000006382f3e ChromeBrowserMainParts::PreMainMessageLoopRun() #24 0x7fcddb593efc content::BrowserMainLoop::PreMainMessageLoopRun() #25 0x7fcdda2e177d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #26 0x7fcdda2e16f4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #27 0x7fcdda2e16a5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content12ChildProcessEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #28 0x7fcdda2e457c _ZN4base8internal7InvokerINS0_9BindStateIMN7content14ServiceFactoryEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #29 0x7fcdda1eed3d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #30 0x7fcddc31bc2d content::StartupTaskRunner::RunAllTasksNow() #31 0x7fcddb58f5ff content::BrowserMainLoop::CreateStartupTasks() #32 0x7fcddb59c3a7 content::BrowserMainRunnerImpl::Initialize() #33 0x7fcddb587659 content::BrowserMain() #34 0x7fcddd406f07 content::RunBrowserProcessMain() #35 0x7fcddd409480 content::ContentMainRunnerImpl::Run() #36 0x7fcddd3fdb95 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #37 0x7fcdd5cdede4 service_manager::Main() #38 0x7fcddd403df5 content::ContentMain() #39 0x0000072cfd6c content::BrowserTestBase::SetUp() #40 0x000006211ce8 InProcessBrowserTest::SetUp() #41 0x000002d48cde _ZN7testing8internal12InvokeHelperIN16sync_file_system18RemoteServiceStateENSt3__15tupleIJEEEE12InvokeMethodINS2_25MockRemoteFileSyncServiceEMS9_KFS3_vEEES3_PT_T0_RKS6_ #42 0x00000429ac82 testing::internal::HandleExceptionsInMethodIfSupported<>() #43 0x00000427de24 testing::Test::Run() #44 0x00000427e8a0 testing::TestInfo::Run() #45 0x00000427f34f testing::TestCase::Run() #46 0x000004291708 testing::internal::UnitTestImpl::RunAllTests() #47 0x0000042a53ee testing::internal::HandleSehExceptionsInMethodIfSupported<>() #48 0x00000429c2b2 testing::internal::HandleExceptionsInMethodIfSupported<>() #49 0x000004291367 testing::UnitTest::Run() #50 0x0000062546c1 RUN_ALL_TESTS() #51 0x000006250f8b base::TestSuite::Run() #52 0x000006169758 ChromeTestSuiteRunner::RunTestSuite() #53 0x000006169863 ChromeTestLauncherDelegate::RunTestSuite() #54 0x00000734aaa9 content::LaunchTests() #55 0x00000616ab52 LaunchChromeTests() #56 0x00000616967b main #57 0x7fcdc10222b1 __libc_start_main #58 0x000001e4a02a _start [0622/133003.126182:ERROR:kill_posix.cc(83)] Unable to terminate process group 246755: No such process (3) [1/1] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest (TIMED OUT) 1 test timed out: QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest (../../chrome/test/remoting/webapp_javascript_browsertest.cc:25)
,
Jun 25 2018
What is UserActivationV2, and what's the timeline for it being enabled by default? These browser tests are for the Chrome Remote desktop app, which is deprecated so I'm inclined to say the tests can simply be disabled (I just tried to run the sample command-line and no tests were run, so perhaps they have already been disabled).
,
Jun 25 2018
User Activation v2 is a new way to track user gesture (or activation) in a page/frame. More info in Issue 696617 and in the design doc: https://docs.google.com/document/d/1XL3vCedkqL65ueaGVD-kfB5RnnrnTaxLc7kmU91oerg/edit?usp=sharing We plan to ship it in M70. The test failure is blocking us. Your comment about being deprecated makes sense. The test is disabled in debug build, which looked suspicious to me. I ran the test by dropping "MAYBE_" from this line: https://cs.chromium.org/chromium/src/chrome/test/remoting/webapp_javascript_browsertest.cc?rcl=339ab9726bcba21566853bf88ca9c6fbcd885370&l=19 A clarification question: your "deprecation comment" is about the test or the CRD app? In any case, I will send you a CL to disable the test.
,
Jun 25 2018
The app is deprecated, so there isn't much value in continuing to run these browser tests against it. They only test very basic functionality in any case.
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99c41e77ff985024a8080a2bdf8674caac9aa6a7 commit 99c41e77ff985024a8080a2bdf8674caac9aa6a7 Author: Mustaq Ahmed <mustaq@google.com> Date: Tue Jun 26 17:20:37 2018 Disabled Remoting_Webapp_Js_Unittest The test has past issues, and also fails with User Activation v2. Since the code being tested is deprecated, it only makes sense to disbale the test. Bug: 855655 Change-Id: I6f997e8b341c09135b021068c44191d12bd939a9 Reviewed-on: https://chromium-review.googlesource.com/1115085 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#570441} [modify] https://crrev.com/99c41e77ff985024a8080a2bdf8674caac9aa6a7/chrome/test/remoting/webapp_javascript_browsertest.cc
,
Jun 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mustaq@chromium.org
, Jun 22 2018Cc: mustaq@chromium.org jamiewa...@chromium.org
Components: Services>Chromoting Blink>Input
Labels: UserActivation
Status: Available (was: Unconfirmed)