Fix logic for whether or not to enabled Scroll Anchor Serialization |
|||||
Issue descriptionThis was inadvertently disabled in a distantly related refactoring(root layer scrolling). Change has already landed in https://chromium.googlesource.com/chromium/src/+/1702b04825afe60a2256a9ab242a21fa7ea1c8ef this bug is for tracking purposes.
,
Jun 25 2018
Why does this need to be merged to M68 vs waiting until M69?
,
Jun 25 2018
It doesn't strictly need to merged to 68, but we're running Finch experiments that are currently useless due to this being accidentally turned off. We'd prefer not to have to wait for 69 to start collecting data again.
,
Jun 25 2018
How safe is this merge overall and well tested in canary?
,
Jun 25 2018
I believe it's pretty safe. The change is small and re-enables a feature that was previously tested, stable and working in canary, dev, and beta before being inadvertently deactivated. The feature is currently performing as expected in Canary according to both manual testing and UMA, and has normal stability numbers.
,
Jun 26 2018
Approving merge to M68. Branch:3440
,
Jul 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 2
The merge commit wasn't auto-linked to this bug. It landed at refs/branch-heads/3440@{#531} on the 26th
See https://crrev.com/c/1115378
,
Jul 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sheriffbot@chromium.org
, Jun 22 2018