New issue
Advanced search Search tips

Issue 855652 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Fix logic for whether or not to enabled Scroll Anchor Serialization

Project Member Reported by pnoland@chromium.org, Jun 22 2018

Issue description

This was inadvertently disabled in a distantly related refactoring(root layer scrolling).

Change has already landed in https://chromium.googlesource.com/chromium/src/+/1702b04825afe60a2256a9ab242a21fa7ea1c8ef this bug is for tracking purposes. 

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 22 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Why does this need to be merged to M68 vs waiting until M69?
It doesn't strictly need to merged to 68, but we're running Finch experiments that are currently useless due to this being accidentally turned off. We'd prefer not to have to wait for 69 to start collecting data again. 
How safe is this merge overall and well tested in canary?
I believe it's pretty safe. 

The change is small and re-enables a feature that was previously tested, stable and working in canary, dev, and beta before being inadvertently deactivated. 

The feature is currently performing as expected in Canary according to both manual testing and UMA, and has normal stability numbers. 
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to M68. Branch:3440
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 2

Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Merged
The merge commit wasn't auto-linked to this bug. It landed at refs/branch-heads/3440@{#531} on the 26th

See https://crrev.com/c/1115378
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 6

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Approved-68

Sign in to add a comment