New issue
Advanced search Search tips

Issue 855644 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 872088
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"Enable debugging features" cannot proceed or cancel

Project Member Reported by kaznacheev@chromium.org, Jun 22 2018

Issue description

Chrome Version: 69.0.3464.0
OS: ChromeOS 10798.0.0

What steps will reproduce the problem?
(1) In OOBE click "Enable debugging features"
(2) In the next screen click "Proceed" or "Cancel"

What is the expected result?
should proceed to enable or cancel

What happens instead?
Proceed reboots the system and pops up the same screen.
Cancel just re-opens the same screen.



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Cc: r...@chromium.org abodenha@chromium.org jdufault@chromium.org alemate@chromium.org
Owner: agawronska@chromium.org
I am seeing the same thing on grunt-release/R70-10971.0.0 after doing:

cros flash --board=grunt ${IP} xbuddy://remote/grunt/latest-canary/test --disable-rootfs-verification --clobber-stateful

Possibly a duplicate of 872088, although that bug seems to be targeting R69 specifically, and I am seeing this on canary (R70).

Labels: ReleaseBlock-Dev M-70
If this is only in dev mode, we don't necessarily need to block on this, moreover if this has been around since June, it is probably already there on the dev channel anyway?
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Moving this to ReleaseBlock-Beta. We should be able to live with this in Dev and fix it for Beta. Please change if you believe this is not correct. Thanks.
Friendly ping to get an update as it is marked as RBB. Thanks
It looks that chrome never receives the signal that debugging was enabled and never clears the corresponding pref. Will post more updates tomorrow.
Owner: benchan@chromium.org




Here is what happens on chromium side:
* Dialog to enabled debugging is shown
* Device is rebooted
* It is expected that rootfs verification will be removed at that point, but it never is. We are stuck at the following piece of code: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc?rcl=b1a9183dd954533f233fe3fa51f88bc96b72b257&l=250

Re:Comment 5
The rootfs verification flag is never set, so we never clear kDebuggingFeaturesRequested pref. When cancel is pressed we go back to welcome screen, but welcome screen is checking the pref again and showing enable debugging screen again. I believe this is the correct behavior.

It looks like the problem lies on the platform side.
I was able to narrow it down to between 10738.0.0 and 10739.0.0.
Chromium version didn't change then and was 69.0.3445.0.

Changelog: https://crosland.corp.google.com/log/10738.0.0..10739.0.0
There is one change to debugd there [1], but it is outside of my area of expertise and it is hard to judge for me.

We need someone from Platform team to have a look at it.

Re-assigning.
Friendly ping. Checking on the progress of these RBBs, please update with an ETA on fixes if this issue is still an RBB. Otherwise please remove the RBB label. Thanks.
Checking on the progress of these RBBs, please update with an ETA on fixes if this issue is still an RBB. 

Otherwise please remove the RBB label. Thanks.
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to RBS.
Cc: vapier@chromium.org
Mergedinto: 872088
Status: Duplicate (was: Untriaged)
this should be fixed now via  issue 872088  and has been backported to R69/R70 already

Sign in to add a comment