New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855639 link

Starred by 2 users

Issue metadata

Status: WontFix
Merged: issue 855136
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Merge perf results from obbs shards instead of concat

Project Member Reported by eyaich@chromium.org, Jun 22 2018

Issue description

Simon found some errors with benchmark_total_duration metric that was duplicated across shards since we currently just concat results: https://cs.chromium.org/chromium/src/tools/perf/process_perf_results.py?q=process_perf_results&sq=package:chromium&g=0&l=297

There are other summary metrics that require total benchmark aggregation.  

Ethan mentioned an add_histogram call that we could use in catapult.  I am slightly worried about that given the latency of the upload already.  
 

Comment 1 by eyaich@chromium.org, Jun 22 2018

Mergedinto: 855136
Status: Duplicate (was: Untriaged)

Comment 2 by eyaich@chromium.org, Jun 22 2018

Status: Available (was: Duplicate)

Comment 3 by eyaich@chromium.org, Jun 22 2018

Cc: eyaich@chromium.org
 Issue 855136  has been merged into this issue.

Comment 4 by eyaich@chromium.org, Jun 25 2018

Summary: Remove benchmark_duration (was: Merge perf results from obbs shards instead of concat)
After we met we have decided to remove benchmark_duration from telemetry.  Ethan is going to file a bug to re-investigate the right solution to this.  The thought it that we all a histogram per story duration and aggregate in add_reserve_diagnostics, but that is on hold for now.  I will file a bug for removing benchmark_duration

Comment 5 by eyaich@chromium.org, Jun 25 2018

Labels: OS-iOS
Status: WontFix (was: Available)
Summary: Merge perf results from obbs shards instead of concat (was: Remove benchmark_duration )

Sign in to add a comment