PIN settings with policy strings validation strings have off by one error |
||
Issue descriptionIf pin length must be set then the error messages for - [0,3] digits: "PIN must be at least 4 digits" - [5..] digits: "PIN must be less than 4 digits" The 5.. digit case should be "PIN must be less than 5 digits"
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ab0de570765fd0c702a8a66454c4abd778ffa0 commit 77ab0de570765fd0c702a8a66454c4abd778ffa0 Author: Jacob Dufault <jdufault@google.com> Date: Fri Jun 22 19:10:23 2018 cros: Fix off-by-one error in PIN settings. If pin length must be set then the error messages for - [0,3] digits: "PIN must be at least 4 digits" - [5..] digits: "PIN must be less than 4 digits" The 5.. digit case should be "PIN must be less than 5 digits" Bug: 855635 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I840772182b292f150626aa670594221bd1096904 Reviewed-on: https://chromium-review.googlesource.com/1112210 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569724} [modify] https://crrev.com/77ab0de570765fd0c702a8a66454c4abd778ffa0/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
,
Jun 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by jdufault@chromium.org
, Jun 22 2018