New issue
Advanced search Search tips

Issue 855620 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 879777
issue 879783
issue 879784

Blocking:
issue 773295



Sign in to add a comment

Migrate //components/data_reduction_proxy to network::SimpleURLLoader

Project Member Reported by reillyg@chromium.org, Jun 22 2018

Issue description

There are a number of classes in this directory that need to be migrated from net::URLFetcher to network::SimpleURLLoader:

https://cs.chromium.org/search/?q=URLFetcher+file:%5Esrc/components/data_reduction_proxy/+package:%5Echromium$&type=cs
 

Comment 1 by dxie@google.com, Jun 26 2018

Labels: Proj-Servicification-network-url

Comment 2 by dxie@google.com, Jun 26 2018

Labels: Proj-Servicification-Canary
Owner: pilgrim@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33edf124e533a52021e18073a20a47a84f4126e

commit e33edf124e533a52021e18073a20a47a84f4126e
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Thu Jun 28 17:03:25 2018

Migrate DataReductionProxyPingbackClientImpl to SimpleURLLoader

Bug:  855620 

Change-Id: Id4da3e42581147261f706c15f3649a38fad52ff1
Reviewed-on: https://chromium-review.googlesource.com/1117031
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571167}
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/components/data_reduction_proxy/content/browser/BUILD.gn
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/components/data_reduction_proxy/content/browser/DEPS
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.cc
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.h
[modify] https://crrev.com/e33edf124e533a52021e18073a20a47a84f4126e/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc

Owner: reillyg@chromium.org
Status: Assigned (was: Started)
pilgrim@ has an in-progress CL which I will pick up soon: https://chromium-review.googlesource.com/c/chromium/src/+/1122697
Labels: -OS-Linux -OS-Windows -OS-Chrome -OS-Mac
@reillyg: are you working on this, or should we take over?
Owner: svil...@igalia.com
I haven't started work on it yet. It's all yours.
Cc: cduvall@chromium.org
What's the status of this migration? It would be great to get this done soon as we are going to start migration data_reduction_proxy to network service very soon. Also looks like there are separate bugs for each file that needs to be migrated in the data_reduction_proxy directory:  issue 879777 ,  issue 879783 , and  issue 879784 .
Cc: jam@chromium.org
Owner: ----
Status: Available (was: Assigned)
I am no longer working on that. The work was suspended as the priority was the Windows Canary blockers.

Apart from that, if I am not wrong there were some decissions to be made before going on with the migration. I think John could provide more details here. Adding him to Cc.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357996d73872c84c9687882ca1592e657944f3b5

commit 357996d73872c84c9687882ca1592e657944f3b5
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Oct 09 19:19:38 2018

Remove orphan histogram DataReductionProxy.ConfigService.SentVariationHeaders

This is a driven-by / preparation CL to migration
DataReductionProxyConfigServiceClient to use SimpleURLLoader (over
URLFetcher).

As per tbansal@ comment in [1], this histogram is not useful anymore.

[1] https://crrev.com/c/1271175#message-d675bd68a0cc6f93ba5211900d9ea6cdfee09fcb

BUG= 855620 

Change-Id: I536e1760bd2d410401ebe68549fa39eab7a8344c
Reviewed-on: https://chromium-review.googlesource.com/c/1271495
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#598032}
[modify] https://crrev.com/357996d73872c84c9687882ca1592e657944f3b5/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/357996d73872c84c9687882ca1592e657944f3b5/tools/metrics/histograms/histograms.xml

Blockedon: 879783 879784 879777
Blocking: 773295
Status: Fixed (was: Available)
I am closing this bug as fixed since the 3 blockers are also fixed.

Please reopened if there is more work to be done.
Owner: toniki...@chromium.org

Sign in to add a comment