New issue
Advanced search Search tips

Issue 855619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Swarming: /botlist: make columns show the longest most significant value, not the first one

Project Member Reported by mar...@chromium.org, Jun 22 2018

Issue description

Background:
When a bot advertises dimension values, they are returned ordered.

When a value is created out of split items, like done in issue 762161, where 'zone': ['us', 'us-central', 'us-central1', 'us-central1-c'], the first value is the most broad/less informative one.

Actual:
- Zone column displays the less precise item, 'us'.

Expected:
- Zone column displays the most precise item, 'us-central1-c'.

AI:
- Figure out a way to detect this case and:
  - Skip the display of common prefixes
  - Display values that are not a prefix of others

_pool_from_dimensions() has similar algorithm.
Ref: https://cs.chromium.org/chromium/infra/luci/appengine/swarming/ts_mon_metrics.py?l=259
 

Comment 2 by mar...@chromium.org, Jun 22 2018

Yep in this case it's for the elements in botlist.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/40ef70ec55f6969f57e85a76c9135fe6138bd66a

commit 40ef70ec55f6969f57e85a76c9135fe6138bd66a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jun 22 17:03:28 2018

Default to longest

This affects tasklist and botlist and is probably what we want
in all cases.  If we don't want this for a particular column,
we can just special case it.

Bug:  855619 
Change-Id: Ic97446cd9b1fc5de8c02fa766110bb7a926380b2
Reviewed-on: https://chromium-review.googlesource.com/1112048
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/40ef70ec55f6969f57e85a76c9135fe6138bd66a/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/40ef70ec55f6969f57e85a76c9135fe6138bd66a/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html

Cc: -kjlubick@chromium.org
Owner: kjlubick@chromium.org
Status: Fixed (was: Available)
This is live in old and new UI.

Sign in to add a comment