Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)
What steps will reproduce the problem?
(1) fetch v8
(2) edit, git add, git commit
(3) git cl upload
What is the expected result?
The changes are uploaded to gerrit.
What happens instead?
Fails to process the file.
Note: this has been working for me for over a month now.
Details below
------------------------------
bstell@bstell:$ git cl upload -r gsathya@chromium.org,bmeurer@chromium.org --cc=cira@chromium.org
Running presubmit upload checks ...
Done processing /usr/local/google/home/bstell/2v8/v8/src/objects/intl-objects.cc
Total errors found: 0
Failed to process /usr/local/google/home/bstell/2v8/v8/src/objects/intl-objects.cc
Total errors found: 1
Total violating files: 0
** Presubmit ERRORS **
C++ lint check failed
Presubmit checks took 1.3s to calculate.
Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.
Please use labels and text to provide additional information.
If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
------------------------------
bstell@bstell:$ git cl presubmit -v
Running presubmit commit checks ...
Running /usr/local/google/home/bstell/2v8/v8/PRESUBMIT.py
Done processing /usr/local/google/home/bstell/2v8/v8/src/objects/intl-objects.cc
Total errors found: 0
Failed to process /usr/local/google/home/bstell/2v8/v8/src/objects/intl-objects.cc
Total errors found: 1
Total violating files: 0
Running /usr/local/google/home/bstell/2v8/v8/src/PRESUBMIT.py
** Presubmit ERRORS **
OWNERS check failed: this CL has no Gerrit change number, so we can't check it for approvals.
C++ lint check failed
Presubmit checks took 1.4s to calculate.
Comment 1 by gsat...@chromium.org
, Jun 22 2018Components: Infra