New issue
Advanced search Search tips

Issue 855613 link

Starred by 1 user
Status: WontFix
Owner:
sky@chromium.org
Closed: Jul 10
Cc:
sadrul@chromium.org
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Refactor reconnection logic out of VizProcessTransportFactory into HostContextFactoryPrivate

Project Member Reported by sky@chromium.org, Jun 22 2018 
I refactored the ContextFactoryPrivate parts of VPTF into HCFP here: https://chromium-review.googlesource.com/c/chromium/src/+/1105307 . One of the things I did not refactor is the code for attempting to reestablish connections. Specifically the conditional in VizProcessTransportFactory::OnEstablishedGpuChannel around gpu_compositing and the PostTask. That likely needs to be refactored to HFCP.

Comment 1 by sky@chromium.org, Jul 10

Status: WontFix (was: Assigned)
Sadrul says the right fix for this is to make DefaultGpuHost have the reconnection logic. I'm going to file a new bug for that.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e51bec1051153f126a6b3f60c2fe96dd3f7f2aec

commit e51bec1051153f126a6b3f60c2fe96dd3f7f2aec
Author: Scott Violet <sky@chromium.org>
Date: Tue Jul 10 22:24:17 2018

chromeos: update TODO

HostContextFactoryPrivate shouldn't have reconnection logic, instead
DefaultGpuHost should.

TEST=none
BUG= 855613 
TBR=sadrul@chromium.org

Change-Id: I23b927997b0be98268123acd4cc09015cf12bc8e
Reviewed-on: https://chromium-review.googlesource.com/1132295
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573950}
[modify] https://crrev.com/e51bec1051153f126a6b3f60c2fe96dd3f7f2aec/ui/compositor/host/host_context_factory_private.cc
►

Sign in to add a comment