New issue
Advanced search Search tips

Issue 855609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Update views_mus and views_mus_interactive_ui_tests to use test_ws

Project Member Reported by sky@chromium.org, Jun 22 2018

Issue description

These suites are using services/ui/ws as the backend, they should be using ws2. Best way to do that is to have them get ws2 from test_ws.
 
Blocking: 837713
Blockedon: 864614
Blockedon: 864615
Blockedon: 864616
Blockedon: 864618
Blockedon: 864787
Blockedon: 864800
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c

commit 6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Jul 19 01:43:02 2018

Make views_mus_unittests and views_mus_interactive_ui_tests use ws2

Make test_ws implement ServiceFactory and package the ui service.
Bind a ws2::WindowService instance to requests for the ui service.
Bind test WindowTreeHostFactory requests in WindowService's registry.
Have the test suites use test_ws + ui services instead of test_wm.

Add a TestGpuInterfaceInterfaceProvider with stub binding functions.
(that and an EventInjector registration placeholder prevent crashes)

Move shadow elevation property registration to ws2::WindowService.

Disable some broken mus-only tests, early return if IsMus from some others.
Remove the old ws service_unittests (catalog conflict packaging ui service)

Bug:  855609 
Test: Automated, no regressions.
Change-Id: I58f65551c9c0e1c734ed4ac752b5219ecbead0db
Reviewed-on: https://chromium-review.googlesource.com/1138749
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576310}
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/BUILD.gn
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/test_ws/BUILD.gn
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/test_ws/manifest.json
[add] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/test_ws/test_gpu_interface_provider.cc
[add] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/test_ws/test_gpu_interface_provider.h
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/test_ws/test_ws.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/ws2/test_manifest.json
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/ws2/window_service.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/mus/BUILD.gn
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/mus/drag_interactive_uitest.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/6374eaa6aaa0aff9cd393bc9c0c7b5b482092e5c/ui/views/widget/widget_unittest.cc

Status: Fixed (was: Assigned)
The only outstanding failure is tracked in Issue 864787; marking this Fixed.

Sign in to add a comment