New issue
Advanced search Search tips

Issue 855599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 800418



Sign in to add a comment

Make TWA failure state look like CCT state

Project Member Reported by peconn@chromium.org, Jun 22 2018

Issue description

When a TWA fails verification it shows a toolbar similar to that of a Custom Tab. The Custom Tab toolbar has been updated recently, update the TWA toolbar to look like it.

 
CustomTab.png
386 KB View Download
TrustedWebActivityVerificationFailed.png
390 KB View Download

Comment 1 by peconn@chromium.org, Jun 22 2018

Components: UI>Browser>Mobile>CustomTabs

Comment 2 by peconn@chromium.org, Jun 26 2018

Labels: -Pri-1 Pri-2
This is probably a P2 since the current behaviour is fully functional and this is a rare error state that indicated the developer is doing something wrong.
I agree. This should be non-blocking in the UI deck.
So recent update includes changing the colour of the toolbar (to match Modern Design).

The title being shown is dependent on setShowTitle being called on the CustomTabsIntent - we should make the error state pay attention to this.
Status: Fixed (was: Assigned)
Fixed in the refactor (Issue 871266).

Sign in to add a comment