New issue
Advanced search Search tips

Issue 855587 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
perezju@chromium.org
nedngu...@google.com
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

telemetry tests still pass when video is broken

Project Member Reported by kylec...@chromium.org, Jun 22 2018 
I added error handling code for IPC connection error for video CompositorFrameSinks that would detect when the connection to the display compositor was lost. This ended up exposing some bugs and causing crashes on Android WebView (see  crbug.com/853204  for more details on that).

This also points to another problem, before I landed a patch to detect connection errors system_health.common_mobile and system_health.memory_mobile were running and passing on Android WebView. All pages that included video just had an empty rectangle where the video was supposed to be though.

I believe you can see evidence of that in the last passing trace here in https://pinpoint-dot-chromeperf.appspot.com/job/107d15b9240000. I also confirmed by running the benchmark locally.

This is possible because most of the tab content and the video content are now submitted to separate CompositorFramesSinks and composited together by the display compositor. The video CompositorFrames weren't reaching the display compositor so no video showed up. The same thing could happen with OOPIFs too.

Comment 1 by perezju@chromium.org, Jun 22 2018 

I'm not sure about this.

Telemetry is intended to be a performance testing framework for Chrome. The fact that we also sometimes act as a "stability" or "correctness" test because we'll notice if Chrome crashes in the middle of the test is sort of incidental.

Is there a correctness test that could be implemented elsewhere to prevent something like  issue 853204  occurring again?

Alternatively, if there is no other choice and it's important for the story (e.g. browse:media:youtube) to make sure that video is actually loaded, that's a check that should be added for that particular story, and not in general for all of Telemetry.

Comment 2 by nednguyen@chromium.org, Jun 22 2018

Cc: crouleau@chromium.org

Comment 3 by kylec...@chromium.org, Jun 25 2018 

Ideally another correctness test could catch problems but  crbug.com/853204  was caused by the intersection of a couple issues: Android WebView as a platform isn't fully distinct from Android, field trial testing configs work different than finch field trials and a big change to how video works was being finch trialled but didn't work with Android WebView.

I'm not working on any of those projects and I'm not familiar with the testing around them. It might just have been a weird enough bug that no existing correctness tests caught it. Feel free to close as WontFix if that's appropriate.

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment