views_mus_unittests BubbleFrameViewTest.LayoutWithIcon reads uninitialized memory |
|||
Issue descriptionI'm adding views_mus_unittests to the memory bots. The msan bot complains about reading uninitialized memory in BubbleFrameViewTest.LayoutWithIcon: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_chromeos_msan_rel_ng/800 https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943080129439898576%2F%2B%2Fsteps%2Fviews_mus_unittests__with_patch_%2F0%2Flogs%2FBubbleFrameViewTest.LayoutWithIcon%2F0 Uninitialized bytes in __interceptor_send at offset 712 inside [0x727000003800, 13640) ==17147==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x26250c6 in mojo::edk::(anonymous namespace)::ChannelPosix::WriteNoLock(mojo::edk::(anonymous namespace)::MessageView) ./../../mojo/edk/system/channel_posix.cc:396:18 #1 0x2620b39 in mojo::edk::(anonymous namespace)::ChannelPosix::Write(std::__1::unique_ptr<mojo::edk::Channel::Message, std::__1::default_delete<mojo::edk::Channel::Message> >) ./../../mojo/edk/system/channel_posix.cc:126:14 #2 0x25b10d1 in mojo::edk::NodeChannel::WriteChannelMessage(std::__1::unique_ptr<mojo::edk::Channel::Message, std::__1::default_delete<mojo::edk::Channel::Message> >) ./../../mojo/edk/system/node_channel.cc:888:15 #3 0x25b4792 in mojo::edk::NodeChannel::SendChannelMessage(std::__1::unique_ptr<mojo::edk::Channel::Message, std::__1::default_delete<mojo::edk::Channel::Message> >) ./../../mojo/edk/system/node_channel.cc:375:3 #4 0x25c8336 in mojo::edk::NodeController::SendPeerEvent(mojo::edk::ports::NodeName const&, std::__1::unique_ptr<mojo::edk::ports::Event, std::__1::default_delete<mojo::edk::ports::Event> >) ./../../mojo/edk/system/node_controller.cc:608:11 #5 0x25caa84 in mojo::edk::NodeController::ForwardEvent(mojo::edk::ports::NodeName const&, std::__1::unique_ptr<mojo::edk::ports::Event, std::__1::default_delete<mojo::edk::ports::Event> >) ./../../mojo/edk/system/node_controller.cc:686:5 #6 0x5378213 in mojo::edk::ports::Node::SendUserMessageInternal(mojo::edk::ports::PortRef const&, std::__1::unique_ptr<mojo::edk::ports::UserMessageEvent, std::__1::default_delete<mojo::edk::ports::UserMessageEvent> >*) ./../../mojo/edk/system/ports/node.cc:838:16 #7 0x5377843 in mojo::edk::ports::Node::SendUserMessage(mojo::edk::ports::PortRef const&, std::__1::unique_ptr<mojo::edk::ports::UserMessageEvent, std::__1::default_delete<mojo::edk::ports::UserMessageEvent> >) ./../../mojo/edk/system/ports/node.cc:359:12 #8 0x25c1a9e in mojo::edk::NodeController::SendUserMessage(mojo::edk::ports::PortRef const&, std::__1::unique_ptr<mojo::edk::ports::UserMessageEvent, std::__1::default_delete<mojo::edk::ports::UserMessageEvent> >) ./../../mojo/edk/system/node_controller.cc:251:17 #9 0x25acd77 in mojo::edk::MessagePipeDispatcher::WriteMessage(std::__1::unique_ptr<mojo::edk::ports::UserMessageEvent, std::__1::default_delete<mojo::edk::ports::UserMessageEvent> >) ./../../mojo/edk/system/message_pipe_dispatcher.cc:143:30 #10 0x2575fd6 in mojo::edk::Core::WriteMessage(unsigned int, unsigned long, MojoWriteMessageOptions const*) ./../../mojo/edk/system/core.cc:569:22 #11 0x4025bf2 in WriteMessageNew ./../../mojo/public/cpp/system/message_pipe.h:97:10 #12 0x4025bf2 in mojo::Connector::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/connector.cc:276:0 #13 0x402f41c in mojo::InterfaceEndpointClient::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:242:23 #14 0x5d976d in ui::mojom::WindowTreeProxy::NewTopLevelWindow(unsigned int, unsigned long, base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const&) ./gen/services/ui/public/interfaces/window_tree.mojom.cc:210:28 #15 0x32cb081 in aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:2583:10 #16 0x32cb3b1 in non-virtual thunk to aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:0:0 #17 0x32e4346 in aura::CreateInitParamsForTopLevel(aura::WindowTreeClient*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > >) ./../../ui/aura/mus/window_tree_host_mus_init_params.cc:79:13 #18 0x268d55f in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:323:7 #19 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #20 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #21 0x36f60b0 in Run ./../../base/callback.h:125:12 #22 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #23 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #24 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #25 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #26 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #27 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #28 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #29 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #30 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #31 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #32 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #33 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #34 0x29422a0 in Run ./../../base/callback.h:96:12 #35 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #36 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 #37 0x627699 in views::ViewsTestSuite::RunTests() ./../../ui/views/views_test_suite.cc:33:10 #38 0x585ec0 in main ./../../ui/views/mus/run_all_unittests_mus.cc:8:47 #39 0x7f6598c9ef44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #40 0x4d54d9 in _start ??:0:0 Uninitialized value was stored to memory at #0 0x4f546b in __msan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1492:3 #1 0x2568c76 in mojo::edk::Channel::Message::ExtendPayload(unsigned long) ./../../mojo/edk/system/channel.cc:277:5 #2 0x25fc742 in mojo::edk::UserMessageImpl::AppendData(unsigned int, unsigned int const*, unsigned int) ./../../mojo/edk/system/user_message_impl.cc:496:25 #3 0x2573a84 in mojo::edk::Core::AppendMessageData(unsigned long, unsigned int, unsigned int const*, unsigned int, MojoAppendMessageDataOptions const*, void**, unsigned int*) ./../../mojo/edk/system/core.cc:424:16 #4 0x259b2b3 in MojoAppendMessageDataImpl ./../../mojo/edk/system/entrypoints.cc:91:18 #5 0x406b85a in mojo::internal::Buffer::Allocate(unsigned long) ./../../mojo/public/cpp/bindings/lib/buffer.cc:66:21 #6 0x59af8f in Allocate ./../../mojo/public/cpp/bindings/lib/array_internal.h:285:25 #7 0x59af8f in Serialize ./../../mojo/public/cpp/bindings/lib/array_serialization.h:490:0 #8 0x59af8f in Serialize<mojo::ArrayDataView<unsigned char>, const std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > &, mojo::internal::Buffer *&, mojo::internal::Array_Data<unsigned char>::BufferWriter *&, const mojo::internal::ContainerValidateParams *&, mojo::internal::SerializationContext *&, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:0 #9 0x59af8f in Run<const std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > &> ./../../mojo/public/cpp/bindings/lib/array_serialization.h:407:0 #10 0x59af8f in SerializeElements ./../../mojo/public/cpp/bindings/lib/array_serialization.h:357:0 #11 0x59af8f in mojo::internal::Serializer<mojo::MapDataView<mojo::StringDataView, mojo::ArrayDataView<unsigned char> >, base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const>::Serialize(base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const&, mojo::internal::Buffer*, mojo::internal::Map_Data<mojo::internal::Pointer<mojo::internal::Array_Data<char> >, mojo::internal::Pointer<mojo::internal::Array_Data<unsigned char> > >::BufferWriter*, mojo::internal::ContainerValidateParams const*, mojo::internal::SerializationContext*) ./../../mojo/public/cpp/bindings/lib/map_serialization.h:122:0 #12 0x5d95aa in Serialize<mojo::MapDataView<mojo::StringDataView, mojo::ArrayDataView<unsigned char> >, const base::flat_map<std::__1::basic_string<char>, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > &, mojo::internal::Buffer *&, mojo::internal::Map_Data<mojo::internal::Pointer<mojo::internal::Array_Data<char> >, mojo::internal::Pointer<mojo::internal::Array_Data<unsigned char> > >::BufferWriter *, const mojo::internal::ContainerValidateParams *, mojo::internal::SerializationContext *, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:3 #13 0x5d95aa in ui::mojom::WindowTreeProxy::NewTopLevelWindow(unsigned int, unsigned long, base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const&) ./gen/services/ui/public/interfaces/window_tree.mojom.cc:197:0 #14 0x32cb081 in aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:2583:10 #15 0x32cb3b1 in non-virtual thunk to aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:0:0 #16 0x32e4346 in aura::CreateInitParamsForTopLevel(aura::WindowTreeClient*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > >) ./../../ui/aura/mus/window_tree_host_mus_init_params.cc:79:13 #17 0x268d55f in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:323:7 #18 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #19 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #20 0x36f60b0 in Run ./../../base/callback.h:125:12 #21 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #22 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #23 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #24 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #25 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #26 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #27 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #28 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 Uninitialized value was stored to memory at #0 0x4f546b in __msan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1492:3 #1 0x59b0fa in SerializeElements ./../../mojo/public/cpp/bindings/lib/array_serialization.h:142:7 #2 0x59b0fa in Serialize ./../../mojo/public/cpp/bindings/lib/array_serialization.h:492:0 #3 0x59b0fa in Serialize<mojo::ArrayDataView<unsigned char>, const std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > &, mojo::internal::Buffer *&, mojo::internal::Array_Data<unsigned char>::BufferWriter *&, const mojo::internal::ContainerValidateParams *&, mojo::internal::SerializationContext *&, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:0 #4 0x59b0fa in Run<const std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > &> ./../../mojo/public/cpp/bindings/lib/array_serialization.h:407:0 #5 0x59b0fa in SerializeElements ./../../mojo/public/cpp/bindings/lib/array_serialization.h:357:0 #6 0x59b0fa in mojo::internal::Serializer<mojo::MapDataView<mojo::StringDataView, mojo::ArrayDataView<unsigned char> >, base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const>::Serialize(base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const&, mojo::internal::Buffer*, mojo::internal::Map_Data<mojo::internal::Pointer<mojo::internal::Array_Data<char> >, mojo::internal::Pointer<mojo::internal::Array_Data<unsigned char> > >::BufferWriter*, mojo::internal::ContainerValidateParams const*, mojo::internal::SerializationContext*) ./../../mojo/public/cpp/bindings/lib/map_serialization.h:122:0 #7 0x5d95aa in Serialize<mojo::MapDataView<mojo::StringDataView, mojo::ArrayDataView<unsigned char> >, const base::flat_map<std::__1::basic_string<char>, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > &, mojo::internal::Buffer *&, mojo::internal::Map_Data<mojo::internal::Pointer<mojo::internal::Array_Data<char> >, mojo::internal::Pointer<mojo::internal::Array_Data<unsigned char> > >::BufferWriter *, const mojo::internal::ContainerValidateParams *, mojo::internal::SerializationContext *, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:3 #8 0x5d95aa in ui::mojom::WindowTreeProxy::NewTopLevelWindow(unsigned int, unsigned long, base::flat_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<void> > const&) ./gen/services/ui/public/interfaces/window_tree.mojom.cc:197:0 #9 0x32cb081 in aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:2583:10 #10 0x32cb3b1 in non-virtual thunk to aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:0:0 #11 0x32e4346 in aura::CreateInitParamsForTopLevel(aura::WindowTreeClient*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > >) ./../../ui/aura/mus/window_tree_host_mus_init_params.cc:79:13 #12 0x268d55f in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:323:7 #13 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #14 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #15 0x36f60b0 in Run ./../../base/callback.h:125:12 #16 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #17 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #18 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #19 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #20 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #21 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #22 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #23 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #24 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #25 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #26 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #27 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #28 0x29422a0 in Run ./../../base/callback.h:96:12 #29 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #30 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 Uninitialized value was stored to memory at #0 0x4f546b in __msan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1492:3 #1 0x208a7d7 in __construct_range_forward<unsigned char> ./../../buildtools/third_party/libc++/trunk/include/memory:1665:17 #2 0x208a7d7 in __construct_at_end<unsigned char *> ./../../buildtools/third_party/libc++/trunk/include/vector:1030:0 #3 0x208a7d7 in std::__1::enable_if<(__is_forward_iterator<unsigned char*>::value) && (is_constructible<unsigned char, std::__1::iterator_traits<unsigned char*>::reference>::value), void>::type std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >::assign<unsigned char*>(unsigned char*, unsigned char*) ./../../buildtools/third_party/libc++/trunk/include/vector:1415:0 #4 0x32cac21 in operator= ./../../buildtools/third_party/libc++/trunk/include/vector:1359:9 #5 0x32cac21 in aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:2577:0 #6 0x32cb3b1 in non-virtual thunk to aura::WindowTreeClient::CreateWindowPortForTopLevel(std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > > const*) ./../../ui/aura/mus/window_tree_client.cc:0:0 #7 0x32e4346 in aura::CreateInitParamsForTopLevel(aura::WindowTreeClient*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > > >) ./../../ui/aura/mus/window_tree_host_mus_init_params.cc:79:13 #8 0x268d55f in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:323:7 #9 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #10 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #11 0x36f60b0 in Run ./../../base/callback.h:125:12 #12 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #13 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #14 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #15 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #16 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #17 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #18 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #19 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #20 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #21 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #22 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #23 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #24 0x29422a0 in Run ./../../base/callback.h:96:12 #25 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #26 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 #27 0x627699 in views::ViewsTestSuite::RunTests() ./../../ui/views/views_test_suite.cc:33:10 Uninitialized value was stored to memory at #0 0x4f546b in __msan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1492:3 #1 0x24437c9 in std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > mojo::internal::SerializeImpl<skia::mojom::InlineBitmapDataView, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap const>(SkBitmap const*) ./../../mojo/public/cpp/bindings/lib/serialization.h:83:5 #2 0x2442e7d in Serialize<const SkBitmap> ./gen/skia/public/interfaces/bitmap.mojom.h:220:12 #3 0x2442e7d in mojo::TypeConverter<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap>::Convert(SkBitmap const&) ./../../services/ui/public/cpp/property_type_converters.cc:160:0 #4 0x2691d49 in ConvertTo<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap> ./../../mojo/public/cpp/bindings/type_converter.h:111:10 #5 0x2691d49 in views::MusClient::ConfigurePropertiesFromParams(views::Widget::InitParams const&) ./../../ui/views/mus/mus_client.cc:243:0 #6 0x268d3ef in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:321:7 #7 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #8 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #9 0x36f60b0 in Run ./../../base/callback.h:125:12 #10 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #11 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #12 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #13 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #14 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #15 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #16 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #17 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #18 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #19 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #20 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #21 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #22 0x29422a0 in Run ./../../base/callback.h:96:12 #23 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #24 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 #25 0x627699 in views::ViewsTestSuite::RunTests() ./../../ui/views/views_test_suite.cc:33:10 #26 0x585ec0 in main ./../../ui/views/mus/run_all_unittests_mus.cc:8:47 Uninitialized value was stored to memory at #0 0x4f546b in __msan_memcpy /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:1492:3 #1 0x24442c9 in SerializeElements ./../../mojo/public/cpp/bindings/lib/array_serialization.h:142:7 #2 0x24442c9 in Serialize ./../../mojo/public/cpp/bindings/lib/array_serialization.h:492:0 #3 0x24442c9 in Serialize<mojo::ArrayDataView<unsigned char>, base::span<const unsigned char, 18446744073709551615> &, mojo::internal::Buffer *&, mojo::internal::Array_Data<unsigned char>::BufferWriter *, const mojo::internal::ContainerValidateParams *, mojo::internal::SerializationContext *&, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:0 #4 0x24442c9 in mojo::internal::Serializer<skia::mojom::InlineBitmapDataView, SkBitmap const>::Serialize(SkBitmap const&, mojo::internal::Buffer*, skia::mojom::internal::InlineBitmap_Data::BufferWriter*, mojo::internal::SerializationContext*) ./gen/skia/public/interfaces/bitmap.mojom-shared.h:238:0 #5 0x2443659 in Serialize<skia::mojom::InlineBitmapDataView, const SkBitmap &, mojo::internal::Buffer *&, skia::mojom::internal::InlineBitmap_Data::BufferWriter *&, mojo::internal::SerializationContext *&, nullptr> ./../../mojo/public/cpp/bindings/lib/serialization_forward.h:42:3 #6 0x2443659 in Serialize<const SkBitmap, skia::mojom::internal::InlineBitmap_Data::BufferWriter> ./../../mojo/public/cpp/bindings/lib/serialization.h:44:0 #7 0x2443659 in SerializeAsMessageImpl<skia::mojom::InlineBitmapDataView, const SkBitmap> ./../../mojo/public/cpp/bindings/lib/serialization.h:68:0 #8 0x2443659 in std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > mojo::internal::SerializeImpl<skia::mojom::InlineBitmapDataView, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap const>(SkBitmap const*) ./../../mojo/public/cpp/bindings/lib/serialization.h:79:0 #9 0x2442e7d in Serialize<const SkBitmap> ./gen/skia/public/interfaces/bitmap.mojom.h:220:12 #10 0x2442e7d in mojo::TypeConverter<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap>::Convert(SkBitmap const&) ./../../services/ui/public/cpp/property_type_converters.cc:160:0 #11 0x2691d49 in ConvertTo<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, SkBitmap> ./../../mojo/public/cpp/bindings/type_converter.h:111:10 #12 0x2691d49 in views::MusClient::ConfigurePropertiesFromParams(views::Widget::InitParams const&) ./../../ui/views/mus/mus_client.cc:243:0 #13 0x268d3ef in views::MusClient::CreateDesktopWindowTreeHost(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*) ./../../ui/views/mus/mus_client.cc:321:7 #14 0x268d070 in views::MusClient::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/mus_client.cc:272:9 #15 0x26c16d9 in views::(anonymous namespace)::PlatformTestHelperMus::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ./../../ui/views/mus/views_mus_test_suite.cc:208:22 #16 0x36f60b0 in Run ./../../base/callback.h:125:12 #17 0x36f60b0 in CreateNativeWidget ./../../ui/views/widget/widget.cc:69:0 #18 0x36f60b0 in views::Widget::Init(views::Widget::InitParams const&) ./../../ui/views/widget/widget.cc:334:0 #19 0x34cb46d in CreateBubbleWidget ./../../ui/views/bubble/bubble_dialog_delegate.cc:73:18 #20 0x34cb46d in views::BubbleDialogDelegateView::CreateBubble(views::BubbleDialogDelegateView*) ./../../ui/views/bubble/bubble_dialog_delegate.cc:103:0 #21 0x788923 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:794:20 #22 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #23 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #24 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #25 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #26 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #27 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #28 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #29 0x29422a0 in Run ./../../base/callback.h:96:12 #30 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #31 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 #32 0x627699 in views::ViewsTestSuite::RunTests() ./../../ui/views/views_test_suite.cc:33:10 Uninitialized value was created by a heap allocation #0 0x4fb7bd in __interceptor_malloc /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:915:3 #1 0x27672e9 in base::UncheckedMalloc(unsigned long, void**) ./../../base/process/memory_linux.cc:105:13 #2 0x29bda62 in malloc_nothrow ./../../skia/ext/SkMemory_new_handler.cpp:76:19 #3 0x29bda62 in sk_malloc_flags(unsigned long, unsigned int) ./../../skia/ext/SkMemory_new_handler.cpp:115:0 #4 0x14953a3 in sk_malloc_canfail ./../../third_party/skia/include/private/SkMalloc.h:93:12 #5 0x14953a3 in MakeUsing ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:76:0 #6 0x14953a3 in SkMallocPixelRef::MakeAllocate(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:86:0 #7 0x12afc65 in SkBitmap::tryAllocPixels(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkBitmap.cpp:238:28 #8 0x78a22b in allocPixels ./../../third_party/skia/include/core/SkBitmap.h:515:9 #9 0x78a22b in allocPixels ./../../third_party/skia/include/core/SkBitmap.h:551:0 #10 0x78a22b in SkBitmap::allocN32Pixels(int, int, bool) ./../../third_party/skia/include/core/SkBitmap.h:595:0 #11 0x7888b5 in views::BubbleFrameViewTest_LayoutWithIcon_Test::TestBody() ./../../ui/views/bubble/bubble_frame_view_unittest.cc:791:10 #12 0x250cf92 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #13 0x251082b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #14 0x25122b9 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #15 0x25489c4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #16 0x2547297 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #17 0x293abe0 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #18 0x293abe0 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #19 0x29422a0 in Run ./../../base/callback.h:96:12 #20 0x29422a0 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0 #21 0x2941a7e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10 #22 0x627699 in views::ViewsTestSuite::RunTests() ./../../ui/views/views_test_suite.cc:33:10 #23 0x585ec0 in main ./../../ui/views/mus/run_all_unittests_mus.cc:8:47 #24 0x7f6598c9ef44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
,
Jun 22 2018
TEST_F(BubbleFrameViewTest, LayoutWithIcon) {
...
SkBitmap bitmap;
bitmap.allocN32Pixels(20, 80); <- this is what's uninitialized
Seems easy to fix; I'll make a CL.
,
Jun 22 2018
Thanks for jumping on that. I thought that pattern was safe because I've seen it elsewhere, so there are probably other cleanup opportunities.
,
Jun 22 2018
Oh I see, it's because I didn't call eraseColor after. So never mind.
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f839032453ead2272ed0c4eebb71548b8b760583 commit f839032453ead2272ed0c4eebb71548b8b760583 Author: Nico Weber <thakis@chromium.org> Date: Fri Jun 22 20:45:43 2018 Fix uninitialized memory read in BubbleFrameViewTest.LayoutWithIcon. Bug: 855584 Change-Id: I855566a5a9db76b68f2b182ca95b9617c81a6822 Reviewed-on: https://chromium-review.googlesource.com/1112476 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569755} [modify] https://crrev.com/f839032453ead2272ed0c4eebb71548b8b760583/ui/views/bubble/bubble_frame_view_unittest.cc
,
Jun 22 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e commit 5ecf35f1ab2a0a4e2fda04595383231c251f8a9e Author: Nico Weber <thakis@chromium.org> Date: Mon Jun 25 01:50:22 2018 Enable more tests on the cros memory bots. Enable views_mus_unittests on both lsan/asan and on msan, it should pass now. Enable ozone_unittests and wayland_client_perftests on just msan (they don't pass on lsan/asan yet). With this, linux_chromeos_rel_specific_gtests_asan_bringup is identical to linux_chromeos_rel_specific_gtests and can be removed, and because of _that_, chromium_memory_chromiumos_asan_gtests is identical to linux_chromeos_rel_gtests and can also be removed. As a consequence, tests added to the cros rel bots will be added to the memory bots automatically going forward. TBR=kbr Bug: 843511 Bug: 855580 , 855588 , 855584 , 855585 , 855583 Change-Id: I6a28ebae4c9005ce508f8caef07679a1bb50285c Reviewed-on: https://chromium-review.googlesource.com/1112957 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569949} [modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/chromium.memory.json [modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/test_suites.pyl [modify] https://crrev.com/5ecf35f1ab2a0a4e2fda04595383231c251f8a9e/testing/buildbot/waterfalls.pyl |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 22 2018