Issue metadata
Sign in to add a comment
|
Regression: Reload Button is seen faint in Incognito Mode.
Reported by
aiman.an...@etouch.net,
Jun 22 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3469.2 (Official Build)Revision e4ff3cae966b2eb4c011ef1cd028a48c170fbe94-refs/branch-heads/3469@{#4}(64 Bit) OS: Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) What steps will reproduce the problem? 1. Launch chrome, open NTP and open any valid webpage in Incognito Mode. 2. In Incognito Mode, click on Secure chip and select Site Settings. 3. On site settings page, Reset the setting. 4. Observe the ‘Reload’ Button in Incognito Mode. Actual Result: Reload Button is seen faint. Expected Result: Reload button should not be faint. This is a regression issue, broken in 'M-68’, and below is the bisect provided using per-revision script. Good Bad: 68.0.3409.0(Revision:553715) Bad Build: 68.0.3410.0(Revision:554249) You are probably looking for a change made after 554071 (known good), but no later than 554072 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3de592475a01b8ca67c56d7d708f69757f8c8a22..94c32dea3719244da1079b52ba1c8d6811f8cb3c Suspect: https://chromium.googlesource.com/chromium/src/+/94c32dea3719244da1079b52ba1c8d6811f8cb3c ellyjones@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is Mac OS specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS). Kindly refer the attached screen cast Thank You!
,
Jun 22 2018
,
Jul 3
,
Jul 6
The NextAction date has arrived: 2018-07-06
,
Jul 6
I reproed this locally. As far as I can tell the issue is that NativeThemeDarkAura uses gfx::kGoogleBlue300 for prominent buttons, which looks faint as described.
,
Jul 6
Alternate colors: kGoogleBlue500, kGoogleBlue600, kGoogleBlue700. I like kGoogleBlue600 best, so <https://chromium-review.googlesource.com/c/chromium/src/+/1127924> -> pkasting@ :)
,
Jul 6
> Alternate colors: kGoogleBlue500, kGoogleBlue600, kGoogleBlue700. I like kGoogleBlue600 best, so <https://chromium-review.googlesource.com/c/chromium/src/+/1127924> -> pkasting@ :) CC'ing pkasting@ :)
,
Jul 6
I'm not sure the problem is the button background color. An even bigger problem is that the button text color is white, which does not have good contrast with blue 300. Changing the button background to darker makes the button look more enabled, but that's perhaps because the white text now stands out -- but blue 600 doesn't have a wonderful contrast ratio with that background color (< 3). I would have maybe instead tried making the font color for that button be dark. Then the button background would stand out (as blue 600 does against white) and the button text would have as well.
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5245a2a060f4e6b0ce1e2913de8da57b392f8263 commit 5245a2a060f4e6b0ce1e2913de8da57b392f8263 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Jul 06 20:45:43 2018 ui: adjust NativeThemeDarkAura prominent button color kGoogleBlue300 is too light on a dark background - it makes the button look disabled. kGoogleBlue600 seems to be the best fit from the existing palette. Bug: 855579 Change-Id: I0b918b45e93bce127d484d3324af3ef46528ac70 Reviewed-on: https://chromium-review.googlesource.com/1127924 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573061} [modify] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/ui/native_theme/native_theme_dark_aura.cc
,
Jul 6
,
Jul 9
Hi, Retested the above issue on Mac(10.12.6,10.13.1,10.13.6,10.14.0) OS using latest canary build #69.0.3486.0 and Issue is fixed. Now, Reload button is not Faint. Kindly review the attached Screen-Cast. Thank You! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Jun 22 2018