New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855574 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Find-In bubble is seen misplaced.

Reported by aiman.an...@etouch.net, Jun 22 2018

Issue description

Chrome Version: 69.0.3469.2 (Official Build)Revision e4ff3cae966b2eb4c011ef1cd028a48c170fbe94-refs/branch-heads/3469@{#4}(64 Bit)
	
OS: Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6).
	       
What steps will reproduce the problem?
1. Launch chrome, open NTP and enter full-screen from traffic signal.
2. Hit CMD+SHIFT+F and click anywhere on screen.
3. Now Hit CMD+F and Observe Find-In Bubble.
 
Actual Result: Find-In bubble is seen misplaced.

Expected Result: Find-In bubble should not be misplaced and should be attached to Omnibox.

This is a regression issue, broken in 'M-69', and below is the bisect provided using per-revision script.

Good Bad 69.0.3455.0 (Revision: 566000)
Bad Build: 69.0.3456.0 (Revision: 566381)

You are probably looking for a change made after 566146 (known good), but no later than 566147 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b2f7667286adf5feabb164f4ca8f5abbc7879e47..5a8bff8ee3902ed0d134cd2e80c4812c37d42451

Suspect: https://chromium.googlesource.com/chromium/src/+/5a8bff8ee3902ed0d134cd2e80c4812c37d42451

erikchen@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is Mac OS specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS).

Kindly refer the attached screen cast from the below link.

https://drive.google.com/drive/folders/1I8azhLzISK88wvlN4_b-2XqGPS1uo_S1?usp=sharing

Thank You!


 
Update: 

Enable 'Use Views browser windows instead of Cocoa' flag from chrome://flags and relaunch the browser.
Cc: manoranj...@chromium.org
Owner: weili@chromium.org
This sounds like a generic fullscreen issue.

Comment 4 by weili@chromium.org, Jun 23 2018

Labels: Needs-Feedback
aiman.ansari@, could you pls clarify that find-it bubble is misplaced in fullscreen mode or after exiting fullscreen (back to normal mode)?

Since (1) is already in fullscreen by clicking on traffic signal, do we still press CMD+SHIFT+F in (2)? If so, it will exit the fullscreen mode. I could not reproduce
your problem.

The only bug I could find is that:
1) Turn off menu option View->'Always show toolbar in full screen';
2) Enter full-screen from traffic signal;
3) Hit CMD+F and Observe Find-In Bubble

In this case, since toolbar is not visible, the Find-it bubble should be at the very top of the screen. But it is placed somewhere in the middle.

Pls describe your test case if it is different from mine, thanks!

Labels: -Needs-Feedback
Hi Weili,

Sorry for the confusion, providing the updated steps below,

1. Freshly install and Launch chrome, Open NTP.
2. On NTP, Right click on Bookmark bar and Check Show Bookmarks bar option.
3. Enter full-screen from traffic signal and Hit CMD+Shift+F to enter into presentation Mode (Uncheck 'Always show toolbar in full screen' from View menu option).
4. Click anywhere on page and press CMD+F
5. Observe the Find-In Bubble.

Kindly review attached screen-cast for reference.

Thank You!
Actual Behaviour.mov
6.6 MB View Download
aiman.ansari@, I think this is fixed on Canary, pls confirm, thanks.
Status: Fixed (was: Assigned)
Hi weili, 

Retested the above issue on latest canary build #69.0.3488.0 using Mac(10.12.6, 10.13.1, 10.13.6, 10.14.0) and issue is fixed now.

Find-In bubble is seen in its proper position.

Kindly review the attached screen-cast for reference.

Thank You!


Canary Behaviour.mov
2.8 MB View Download

Sign in to add a comment