Regression : Text on 'Add language' overlay appears faint.
Reported by
pranjali...@etouch.net,
Jun 22 2018
|
|||||
Issue descriptionChrome version :69.0.3469.3 (Official Build) 471fb2681e8dffc90083b287077ad559e36b5bf6-refs/branch-heads/3469@{#5}(32/64-bit) OS :Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.5, 10.13.6) and Linux(14.04 LTS) OS Steps to reproduce: 1. Launch chrome and navigate to 'chrome://settings/languages'. 2. Click on languages and again click on 'Add languages' 3. Observe 'Add language' overlay. Actual Result: Text on 'Add language' overlay appears faint. Expected Result: Text on 'Add language' overlay should not appear faint. This is a regression issue broken in ‘M-69’ and will soon update other bisect info. Good build: 69.0.3466.0 Bad build: 69.0.3468.0 You are probably looking for a change made after 568957 (known good), but no later than 568965 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f3af0cc5b3cb425aae2b094d87c49da9cb97d22f..f9b9a0c8e47d63178ad3262ca3dc79efef1f3080 Suspect: https://chromium.googlesource.com/chromium/src/+/dbd89b4cfc4611481959c71ba23affe0bf0d9d1a @aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jun 22 2018
Given that the text here is a label for checkboxes, and not just text belonging to a paragraph, I think we should restore previous font color. Namrata WDYT?
,
Jun 22 2018
Makes sense..this is more of a label for checkboxes and can be updated to GG900. Also another comment: The green color under English here should be Google Green 700 or #188038
,
Jun 25 2018
,
Jun 25 2018
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2bb5eddf2eab003acaa22c0463ba693187780d6 commit d2bb5eddf2eab003acaa22c0463ba693187780d6 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 29 02:19:54 2018 Settings: set language list color, add google-green-700 for refresh Bug: 855570 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1263ec15699c5169ac45b1cf19690031d5b26fa6 Reviewed-on: https://chromium-review.googlesource.com/1113909 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571365} [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/chrome/browser/resources/settings/languages_page/add_languages_dialog.html [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/ui/file_manager/gallery/gallery.html [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html [modify] https://crrev.com/d2bb5eddf2eab003acaa22c0463ba693187780d6/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jun 29 2018
,
Jul 2
Update: Rechecked above issue on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.5, 10.13.6) and Linux(14.04 LTS) OS using latest canary build #69.0.3479.0 and issue is fixed. Text on 'Add language' overlay is seen properly. Please refer attached screen cast for reference. Thank You.. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by aee@chromium.org
, Jun 22 2018