New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Viz Android FrameSinkManagerImpl crash at shutdown

Project Member Reported by jonr...@chromium.org, Jun 22 2018

Issue description

OS: Android
Test suite: content_browsertests
Tests: a bunch will list at the bottom
Args: --enable-features=VizDisplayCompositor

Example failing run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/23013

Example failure:
[FATAL:frame_sink_manager_impl.cc(68)] Check failed: sink_map_.empty()
00000000040378ab  logging::LogMessage::~LogMessage()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  0000000004de8d27  viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  0000000004de8f27  viz::FrameSinkManagerImpl::~FrameSinkManagerImpl()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     ??:0:0
  0000000003d8de4b  viz::VizMainImpl::TearDownOnCompositorThread()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  0000000001fb94e3  void base::internal::Invoker<base::internal::BindState<void (content::GenerateMHTMLAndExitRendererMessageFilter::*)(), base::internal::UnretainedWrapper<content::GenerateMHTMLAndExitRendererMessageFilter> >, void ()>::RunImpl<void (content::GenerateMHTMLAndExitRendererMessageFilter::*)(), std::__ndk1::tuple<base::internal::UnretainedWrapper<content::GenerateMHTMLAndExitRendererMessageFilter> >, 0ul>(void (content::GenerateMHTMLAndExitRendererMessageFilter::*&&)(), std::__ndk1::tuple<base::internal::UnretainedWrapper<content::GenerateMHTMLAndExitRendererMessageFilter> >&&, std::__ndk1::integer_sequence<unsigned long, 0ul>)  ??:0:0
  0000000004027cab  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   ??:0:0
  000000000403ff27  base::internal::IncomingTaskQueue::RunTask(base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  0000000004043497  base::MessageLoop::RunTask(base::PendingTask*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  00000000040437db  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ??:0:0
  0000000004043a07  base::MessageLoop::DoWork()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ??:0:0
  000000000404634b  base::MessagePumpDefault::Run(base::MessagePump::Delegate*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ??:0:0
  0000000004042e63  base::MessageLoop::Run(bool)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ??:0:0
  000000000406091b  base::RunLoop::Run()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   ??:0:0
  000000000409022b  base::Thread::Run(base::RunLoop*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      ??:0:0
  00000000040904a7  base::Thread::ThreadMain()                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             ??:0:0
  00000000040c4067  base::(anonymous namespace)::ThreadFunc(void*)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         ??:0:0
  0000000000066d27  <UNKNOWN>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              /system/lib64/libc.so
  000000000001eb87  <UNKNOWN>           

It looks like we have a shutdown ordering issue. Where we haven't cleared out all sinks before shutdown.

Tests failing:

ContentBrowserTestSanityTest.SingleProcess                                      
DomSerializerTests.SerializeHTMLDOMWithAddingMOTW                               
DomSerializerTests.SerializeHTMLDOMWithBaseTag                                  
DomSerializerTests.SerializeHTMLDOMWithEmptyHead                                
DomSerializerTests.SerializeHTMLDOMWithEntitiesInAttributeValue                 
DomSerializerTests.SerializeHTMLDOMWithEntitiesInText                           
DomSerializerTests.SerializeHTMLDOMWithNonStandardEntities                      
DomSerializerTests.SerializeHTMLDOMWithoutDocType                               
DomSerializerTests.SerializeXMLDocWithBuiltInEntities                           
DomSerializerTests.SubResourceForElementsInNonHTMLNamespace                     
IndexedDBBrowserTestSingleProcess.RenderThreadShutdownTest                      
RenderThreadImplDiscardableMemoryBrowserTest.DiscardableMemoryAddressSpace      
RenderThreadImplDiscardableMemoryBrowserTest.LockDiscardableMemory              
RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeDiscardableMemory       
RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory                  
RenderViewBrowserTest.ConfirmCacheInformationPlumbed                            
ResourceFetcherTests.ResourceFetcher404                                         
ResourceFetcherTests.ResourceFetcherDeletedInCallback                           
ResourceFetcherTests.ResourceFetcherDidFail                                     
ResourceFetcherTests.ResourceFetcherDownload                                    
ResourceFetcherTests.ResourceFetcherPost                                        
ResourceFetcherTests.ResourceFetcherRedirect                                    
ResourceFetcherTests.ResourceFetcherSetHeader                                   
ResourceFetcherTests.ResourceFetcherTimeout                                     
SavableResourcesTest.GetSavableResourceLinksWithPageHasInvalidLinks             
SavableResourcesTest.GetSavableResourceLinksWithPageHasValidLinks               
SavableResourcesTest.GetSavableResourceLinksWithPageHasValidStyleLink           
SingleProcessMemoryTracingTest.BrowserInitiatedSingleDump                       
SingleProcessMemoryTracingTest.ManyInterleavedDumps                             
SingleProcessMemoryTracingTest.RendererInitiatedSingleDump 
 
Labels: -Pri-3 Target-70 Pri-2
Owner: kylec...@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1115875


Sign in to add a comment