New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855546 link

Starred by 1 user
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Aug 16
Cc:
ajha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessarily sign into user Chromebook screen is seen scroll-able when suspending the device and resuming it back

Project Member Reported by rkalavakuntla@chromium.org, Jun 22 2018 
Chrome Version:69.0.3464.0/10805.0.0 dev channel Gnawty,Spring & Falco
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover Build >> In OOBE,go to 'Sign into your Chromebook' screen
(2)Suspend the device >> resume it
(3)Swipe up & down on touch pad to scroll the screen continuously and observe(Please refer video)

Actual: Unnecessarily sign into user Chromebook screen is seen scroll-able 
Expected: Screen shouldn't be unnecessarily scroll-able

This is a Regression issue as same is working fine in M-68 

Note:Issue is not seen in Linux,Windows OS
Actual.mp4
9.9 MB View Download
Expected.mp4
14.0 MB View Download

Comment 1 by jdufault@chromium.org, Jul 19

Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jdufault@chromium.org, Jul 19

Owner: alemate@chromium.org
Looking closer this is actually oobe/webui

Comment 3 by jdufault@chromium.org, Aug 2

Cc: alemate@chromium.org
Owner: qnnguyen@chromium.org
qnnguyen@, can you take a look? This is oobe/webui (not views), so the error should be in JS somewhere.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3963b98df61fe488ddbd007ac5933cf62beff0df

commit 3963b98df61fe488ddbd007ac5933cf62beff0df
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Fri Aug 10 20:19:59 2018

cros: In OOBE, turn off scrolling if the screen fits in the container

Bug:  855546 
Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd
Reviewed-on: https://chromium-review.googlesource.com/1162715
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582312}
[modify] https://crrev.com/3963b98df61fe488ddbd007ac5933cf62beff0df/ui/login/display_manager.js

Comment 5 by qnnguyen@chromium.org, Aug 10

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c86f4a25a967715e1b357d2519a3b5fa75606fa5

commit c86f4a25a967715e1b357d2519a3b5fa75606fa5
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Aug 10 22:12:18 2018

Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"

This reverts commit 3963b98df61fe488ddbd007ac5933cf62beff0df.

Reason for revert: Consistent failures in ProfileWindowWebUIBrowserTest.UserManagerFocusSingleProfile, see e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/36834

Original change's description:
> cros: In OOBE, turn off scrolling if the screen fits in the container
> 
> Bug:  855546 
> Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd
> Reviewed-on: https://chromium-review.googlesource.com/1162715
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582312}

TBR=alemate@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org

Change-Id: Icd9a6648582e8c49bcdbd4bd79d844745d54c2a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  855546 
Reviewed-on: https://chromium-review.googlesource.com/1171703
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582355}
[modify] https://crrev.com/c86f4a25a967715e1b357d2519a3b5fa75606fa5/ui/login/display_manager.js

Comment 7 by qnnguyen@chromium.org, Aug 10

Status: Started (was: Fixed)

Comment 8 by rkalavakuntla@chromium.org, Aug 16 

Issue seems to be fixed,checked with latest available ToT -70.0.3519.3/10973.0.0 dev.
Thanks!

Comment 9 by qnnguyen@chromium.org, Aug 16

Status: Fixed (was: Started)
Thanks for checking for me!
►

Sign in to add a comment