New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855544 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.7% regression in blink_perf.css at 565951:565991

Project Member Reported by alexclarke@chromium.org, Jun 22 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jun 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=855544

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=798d43412e9a8dedbfb52b82a3e185d184700bb91e122548cd727722b2f87df3


Bot(s) for this bug's original alert(s):

linux-perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 23 2018

Cc: mlippautz@chromium.org fergal@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/146257fd240000

CSS: Document Invalidate and do less work for slotted. by fergal@chromium.org
https://chromium.googlesource.com/chromium/src/+/ab7eaacc9f8b4005b6282dc95e932b147daaa2ce
1671 → 1416 (-255.1)

[oilpan] Fix for EsimateLiveSize by mlippautz@chromium.org
https://chromium.googlesource.com/chromium/src/+/aceb7d670d0cca38d219cadfc529390c755c299c
1416 → 1358 (-57.24)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by fergal@chromium.org, Jun 25 2018

Cc: futhark@chromium.org
I'm taking a look at this. It seems quite possible that this 565966 had an impacton CSS performance, although I would expect it to have been slighly positive.

Comment 5 by fergal@chromium.org, Jun 27 2018

There does appear to be a difference when I benchmark on my machine. However, I'm puzzled. I added logging and for the perf test case, nothing changes
- the if() that I moved is evaluated exactly the same number of times before
- InvalidatesSlotted() is always false and so
- the body is executed 0 times

So it's not obvious why this shows a difference
Labels: Performance-Regression-Recovered
Automatic message: All alerts recovered.
Graphs: https://chromeperf.appspot.com/group_report?bug_id=855544
Looking at that graph, it recovered, went bad again and recovered again.
Status: Fixed (was: Assigned)

Sign in to add a comment