New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855542 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15% regression in blink_perf.paint at 567896:567908

Project Member Reported by alexclarke@chromium.org, Jun 22 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jun 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=855542

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=41679cc0901b4f9ca77eb7bd0cb654a4214849712319c53bba234728ae0e334b


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 24 2018

Cc: chrishtr@chromium.org
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15964553240000

De-virtualize LayoutBox::ShouldClipOverflow. by chrishtr@chromium.org
https://chromium.googlesource.com/chromium/src/+/cff6ac338d9d56e3d20039b154a004eda118f24e
188.9 → 224.4 (+35.46)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
The regressions all seem to be related to tests which recompute
SetIsSpanningCollapsedRow or SetIsSpanningCollapsedColumn many times...

But OTOH the regression is in LocalFrameView::paintTree time, which
shouldn't include this cost.
Status: Verified (was: Assigned)
This regression is just on webview and just on 5X, and just on large tables.
Not worth improving.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6f2c2cc014435ddca70caba6722194c8bbbbdd

commit ef6f2c2cc014435ddca70caba6722194c8bbbbdd
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Jun 30 03:16:47 2018

Remove two redundnat else clauses.

TBR=trchen@chromium.org
Bug:  855542 

Change-Id: I4c06b96829b2e7f18924be69b562ac8ccf5bf3bc
Reviewed-on: https://chromium-review.googlesource.com/1121376
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571751}
[modify] https://crrev.com/ef6f2c2cc014435ddca70caba6722194c8bbbbdd/third_party/blink/renderer/core/layout/layout_table_cell.cc

Sign in to add a comment