New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855539 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Unable to download pdf from google drive

Reported by vineetha...@etouch.net, Jun 22 2018

Issue description

Chrome Version: 69.0.3469.3 (Official Build) Revision 471fb2681e8dffc90083b287077ad559e36b5bf6-refs/branch-heads/3469@{#5}(32/64 bit)
OS: Windows(7,10).

Preconditions: 
1)Enable 'Enable network service' flag from chrome://flags
2)Atleast one pdf file should be present under https://drive.google.com

Steps to reproduce:
1. Launch chrome ,navigate to https://drive.google.com and log in with valid credentials .
2. Right click on any pdf file to open the context menu.
3. Now click on 'Download' option and observe.

Actual Result  : PDF file does not get downloaded from google drive.
Expected Result: PDF file should get downloaded from google drive.
 
Above issue is non-regression issue, seen from M69(#69.0.3441.0)

Note:
1)Issue is not seen on Mac and Linux OS.
2)Did this work with Enable network service flag disable?
  Yes



 
ActualVideo.mp4
909 KB View Download
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
Cc: xunji...@chromium.org dxie@chromium.org
Labels: Proj-Servicification-Canary Proj-Servicification
Also we can't download any PDF which are part of gmail attachments.
Labels: -Pri-2 Pri-1
Status: Available (was: Untriaged)
Looks like PDFIFrameNavigationThrottle is not working with network service?

Comment 4 by dxie@chromium.org, Jun 25 2018

Owner: rmcelrath@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3

commit a5adc4ec6539ec4f94986f0a0ba13108eaa218e3
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Tue Jul 03 23:53:09 2018

Fix downloading pdfs with network service.

When the network service is enabled, we wouldn't download responses
that had a plugin associated with their mime type. This makes the
PluginResponseInterceptorUrlLoaderThrottle check if the response
is meant to be a download before intercepting it.

Bug:  855539 
Change-Id: I8b70abb2a7e24c27b5a6866a0f09c24f59c12e05
Reviewed-on: https://chromium-review.googlesource.com/1119581
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572399}
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/browser/plugins/plugin_response_interceptor_url_loader_throttle.cc
[add] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/browser/plugins/plugin_response_interceptor_url_loader_throttle_browsertest.cc
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/test/BUILD.gn
[add] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/test/data/download.pdf
[add] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/chrome/test/data/download.pdf.mock-http-headers
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/BUILD.gn
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/devtools/devtools_url_loader_interceptor.cc
[rename] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/loader/download_utils_impl.cc
[add] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/loader/download_utils_impl.h
[delete] https://crrev.com/555b4daae14cc2ba1be82c5fc930b1156e88345f/content/browser/loader/navigation_loader_util.h
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/public/browser/BUILD.gn
[add] https://crrev.com/a5adc4ec6539ec4f94986f0a0ba13108eaa218e3/content/public/browser/download_utils.h

Status: Fixed (was: Started)
Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Update :
Rechecked the above issue on Windows(7,8,10)OS with latest Canary Chrome version #69.0.3493.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
592 KB View Download

Sign in to add a comment