SurfaceSync Android CompositorImplLowEndBrowserTest failures |
|||
Issue descriptionOS: Android Test suite: content_browsertests Test: P/CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground/0 Args: --enable-surface-synchronization Example failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/23013 I'm seeing two different errors in this test: ../../content/browser/renderer_host/compositor_impl_android_browsertest.cc:208: Failure Value of: compositor->IsLockedForTesting() Actual: false Expected: true And: ../../content/browser/renderer_host/compositor_impl_android_browsertest.cc:190: Failure Value of: rwhva->HasValidFrame() Actual: false Expected: true
,
Jun 22 2018
Test needs to be changed or deleted, compositor lock not used in surface sync
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96c3fbe844559157b93ce3c6dd5f553cdd722b11 commit 96c3fbe844559157b93ce3c6dd5f553cdd722b11 Author: Fady Samuel <fsamuel@chromium.org> Date: Tue Jul 17 23:16:46 2018 Surface Synchronization: Disable CompositorImplLowEndBrowserTest test This test is no longer valid once surface synchronization is on. Bug: 855533 Change-Id: If8feae783911501b7962183b367b0c69d8371e62 Reviewed-on: https://chromium-review.googlesource.com/1141110 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#575835} [modify] https://crrev.com/96c3fbe844559157b93ce3c6dd5f553cdd722b11/content/browser/renderer_host/compositor_impl_android_browsertest.cc [modify] https://crrev.com/96c3fbe844559157b93ce3c6dd5f553cdd722b11/testing/buildbot/filters/viz.android.content_browsertests.filter
,
Jul 18
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e52c3c5226cf89a1c86605b6d2a981742d194a14 commit e52c3c5226cf89a1c86605b6d2a981742d194a14 Author: Jonathan Ross <jonross@chromium.org> Date: Wed Jul 18 14:40:55 2018 Update Surface Sync Filter File In a previous change the failing CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground was set to exit early for surface sync: https://chromium-review.googlesource.com/c/chromium/src/+/1141110 This is because the test is not valid in the surface sync world. It was removed from filtering in Viz configs, but not Surface Sync. This updates that filter too. TEST=P/CompositorImplLowEndBrowserTest.CompositorImplDropsResourcesOnBackground/0 TBR=fsamuel@chromium.org Bug: 855533 Change-Id: I318fb474fd838418b21a38ca421e7fa7cbc326d7 Reviewed-on: https://chromium-review.googlesource.com/1141905 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#576049} [modify] https://crrev.com/e52c3c5226cf89a1c86605b6d2a981742d194a14/testing/buildbot/filters/surface_sync.content_browsertests.filter |
|||
►
Sign in to add a comment |
|||
Comment 1 by jonr...@chromium.org
, Jun 22 2018