New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855508 link

Starred by 2 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Jun 2018
Cc:
omrilio@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : 'Volume' slider and 'Brightness' slider is seen missing when Uber Tray is in Collapsed form

Project Member Reported by mmanchala@chromium.org, Jun 22 2018 
Chrome Version: 69.0.3464.0/10805.0.0 dev channel  Gnawty,Spring & Falco
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->click on Uber Tray ->Now click on 'Collapse' icon  -> Now Uber Tray is in Collapsed Form
(2)Now try to increase or decrease Volume through 'Volume' keys from Keyboard  -> observe 'Volume' slider is not seen and its difficult to find volume level as Volume slider is not available when Uber Tray is in Collapsed form
(3)Issue is also seen for 'Brightness' slider
(Please refer Video)

Expected: 'Volume' slider and 'Brightness' slider should be available even Uber Tray is in Collapsed form
Actual: Instead 'Volume' slider and 'Brightness' slider is seen missing when  Uber Tray is in Collapsed form and its difficult to find Volume level

This is Non-Regression Issue as Collapse and Expand from of Uber Tray is seen from 69.0.3463.0

@tetsui : please confirm the Issue
Actual_NoVolumeSlider.mp4
18.2 MB Download

Comment 1 by tetsui@chromium.org, Jun 25 2018

Cc: omrilio@chromium.org sgabr...@chromium.org
+sgabriel@, +omrilio@: Maybe we should auto-expand system tray when volume keys are pressed?

Comment 2 by sgabr...@chromium.org, Jun 25 2018 

Good catch, yes we should.

Comment 3 by omrilio@chromium.org, Jun 25 2018 

My guess is that you're only thinking of auto-expanding if QS is already open and in minimized mode, right?

If so, sounds good to me.

Comment 4 by tetsui@chromium.org, Jun 26 2018 

#3: That's my understanding.

Comment 5 by tetsui@chromium.org, Jun 26 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14388d9c204ada820cb742069e7c40ec3c75e579

commit 14388d9c204ada820cb742069e7c40ec3c75e579
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Jun 27 03:20:14 2018

Expand UnifiedSystemTray when volume key pressed.

Previously, volume slider was missing when UnifiedSystemTray was
collapsed and volume key was pressed.
This CL ensures UnifiedSystemTray to be expanded when volume key is
pressed.

TEST=manual
BUG= 855508 

Change-Id: Ia1408082a74a9b11a6a7802849c9dc391cf601a8
Reviewed-on: https://chromium-review.googlesource.com/1114520
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570652}
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_slider_bubble_controller.cc
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray.h
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray_bubble.cc
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray_bubble.h
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/14388d9c204ada820cb742069e7c40ec3c75e579/ash/system/unified/unified_system_tray_controller.h

Comment 7 by tetsui@chromium.org, Jun 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment