Issue metadata
Sign in to add a comment
|
UMA consent dialog prevents Chrome restart |
||||||||||||||||||||||
Issue descriptionChrome restarts (e.g. due to site isolation policy) are blocked by the UMA consent notification during new managed user sign in flow. This results in Chrome being in a bad state unable to quit, and the device shows a black screen. Relevant CL: https://chromium-review.googlesource.com/c/chromium/src/+/1086354 Relevant line of code: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_session_manager.cc?l=96&rcl=40f00aa570a7a330acd74192ebacc840e9ca9d58 What steps will reproduce the problem? (1) Enable send diagnostics for the device (2) Enable ARC by policy (3) Disable B&R and GLS by policy (4) Enable site isolation policy (5) Sign in with a new managed account with above policies * Steps 1-3 are necessary to make the UMA dialog show, step 4 causes chrome to restart after sign in, step 5 raises the bug. What is the expected result? User signs in successfully. What happens instead? At the end of the sign in flow (right after you choose a profile picture) the screen turns black. Rebooting the device and signing in again works as expected.
,
Jun 22 2018
Seems related. One difference in behavior is in crbug.com/852816 they could go through the black screen by pressing <ESC>, and that does not happen here. I haven't been able to compile chrome ToT for kevin-arcnext to confirm this is fixed.
,
Jun 22 2018
Should be the same issue. But let me know if the issue is not fixed with my patch.
,
Jun 25 2018
I confirmed that the crash is gone using Chrome 69.0.3473.0.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7da098a199b64a48665d57352e390acc48bfc09d commit 7da098a199b64a48665d57352e390acc48bfc09d Author: Josh Horwich <jhorwich@chromium.org> Date: Fri Jun 29 17:48:07 2018 arc: Make SET_REPORTING_CONSENT false for managed users Keep usage & diagnostics false during ARC setup if the user does not see the ARC ToS dialog due to all relevant settings being managed, even if usage & diagnostics is enabled for the device. Also removes the notification added by crrev.com/c/1086354. Bug: b/73338614, 859104, 855448 Test: Opt in to ARC with managed and unmanaged users Change-Id: If5bd6b10d4059df97af0b6c14c8f8a15ceaaddc0 Reviewed-on: https://chromium-review.googlesource.com/1115712 Commit-Queue: Josh Horwich <jhorwich@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#571532} [modify] https://crrev.com/7da098a199b64a48665d57352e390acc48bfc09d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/7da098a199b64a48665d57352e390acc48bfc09d/chrome/browser/chromeos/arc/arc_session_manager.cc [modify] https://crrev.com/7da098a199b64a48665d57352e390acc48bfc09d/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc [modify] https://crrev.com/7da098a199b64a48665d57352e390acc48bfc09d/components/arc/arc_prefs.cc [modify] https://crrev.com/7da098a199b64a48665d57352e390acc48bfc09d/components/arc/arc_prefs.h
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd644dbff97bae27b58ee5d64e87367a5f8bc18d commit cd644dbff97bae27b58ee5d64e87367a5f8bc18d Author: Josh Horwich <jhorwich@chromium.org> Date: Tue Jul 10 22:04:02 2018 arc: Make SET_REPORTING_CONSENT false for managed users Keep usage & diagnostics false during ARC setup if the user does not see the ARC ToS dialog due to all relevant settings being managed, even if usage & diagnostics is enabled for the device. Note that this is a squashed patch of the following three commits: commit 25a10afd2e5303a00b5f19d2cdd1b5a735723e44 commit c59e0e374abf33db3b17cd269be347a200e7ed64 commit 7da098a199b64a48665d57352e390acc48bfc09d Bug: b/73338614, 859104, 855448 Test: Opt in to ARC with managed and unmanaged users Change-Id: I5fbe412d8cd7e3e0ca0ee77c325ba0903e677414 Signed-off-by: Josh Horwich <jhorwich@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1121212 Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/branch-heads/3440@{#641} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/chrome/browser/chromeos/arc/arc_session_manager.cc [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/chrome/browser/chromeos/arc/arc_util.cc [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/chrome/browser/chromeos/arc/arc_util.h [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/chrome/browser/chromeos/arc/arc_util_unittest.cc [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/components/arc/arc_prefs.cc [modify] https://crrev.com/cd644dbff97bae27b58ee5d64e87367a5f8bc18d/components/arc/arc_prefs.h
,
Jul 23
Verified fixed, no black screen or other issues during sign in to a new managed account with the following policies: (1) Enable send diagnostics for the device (2) Enable ARC by policy (3) Disable B&R and GLS by policy (4) Enable site isolation policy Chrome OS: 10895.0.0 Chrome: 69.0.3497.0 Device: Santa |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bartfab@chromium.org
, Jun 22 2018