New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855409 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7% regression in system_health.memory_mobile at 1529470636:1529482382

Project Member Reported by alexclarke@chromium.org, Jun 22 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jun 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=855409

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0d6a18ce6b3c49a3059d77a0b357f5c2ea65d5f44d419e9ba388f0c7c9b6a4cf


Bot(s) for this bug's original alert(s):

health-plan-clankium-phone
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 24 2018

Cc: jdarpinian@chromium.org
Owner: jdarpinian@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jdarpinian@chromium.org ===

Hi jdarpinian@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : James Darpinian
  Commit : d1b4ae2892b05cf622b3f649cb38b995ed2d1733
  Date   : Tue Jun 19 19:49:08 2018
  Subject: GPU: Don't flush when destroying transfer buffers.

Bisect Details
  Configuration: clankium-phone-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:private_dirty_size_avg/background_social/background_social_facebook
  Change       : 8.42% | 48336349.3333 -> 52408456.0

Revision                                       Result                  N
android-chrome@009b09f963                      48336349 +- 240061      6      good
android-chrome@009b09f963,chromium@568439      48464008 +- 160488      6      good
android-chrome@009b09f963,chromium@568524      48318600 +- 138412      6      good
android-chrome@009b09f963,chromium@568566      48277640 +- 181203      6      good
android-chrome@009b09f963,chromium@568572      48433971 +- 124768      6      good
android-chrome@009b09f963,chromium@568574      48318600 +- 101420      6      good
android-chrome@009b09f963,chromium@568575      52157917 +- 676505      6      bad       <--
android-chrome@009b09f963,chromium@568577      52368179 +- 574010      6      bad
android-chrome@009b09f963,chromium@568587      52278067 +- 489978      6      bad
android-chrome@6d7cb80987                      52223453 +- 517391      6      bad
android-chrome@6c8f6fc4ae                      52408456 +- 349175      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.social.facebook system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8943022668443112960


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 25 2018

 Issue 856063  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 25 2018

 Issue 856050  has been merged into this issue.
This change had a mix of positive and negative effects. I will investigate but I don't think we should revert immediately.

Click the "Hide all improvements" button twice to see the improvements.
https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ-bCtvQoM
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 26 2018

 Issue 856100  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jun 29 2018

Cc: nzolghadr@chromium.org
 Issue 857545  has been merged into this issue.
Mergedinto: 855402
Status: Duplicate (was: Assigned)

Sign in to add a comment