New issue
Advanced search Search tips

Issue 855389 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

More DownloadActivityTest flakes

Project Member Reported by mattcary@chromium.org, Jun 22 2018

Issue description

All on android M 64 bit as far as I could tell, and involving the following error. I will disable a bunch of them.


android.os.StrictMode$StrictModeViolation: policy=1900575 violation=2
	at android.os.StrictMode.executeDeathPenalty(StrictMode.java:1505)
	at android.os.StrictMode.-wrap3(StrictMode.java)
	at android.os.StrictMode$AndroidBlockGuardPolicy.handleViolation(StrictMode.java:1498)
	at android.os.StrictMode$AndroidBlockGuardPolicy$1.run(StrictMode.java:1380)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5417)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
 
Sorry, I need to clarify: these are failures and not just flakes AFAICT
Labels: sheriff-android
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a056347fdafc4b51c36d4315f4ba7c0754c05f

commit f1a056347fdafc4b51c36d4315f4ba7c0754c05f
Author: Matthew Cary <mattcary@chromium.org>
Date: Fri Jun 22 15:21:50 2018

Disable failing DownloadActivityTests.

These all appear to be due to a strict mode violation on android M 64
bit.

TBR=dtrainor@chromium.org

Bug: 855389
Change-Id: I20297e805bee3d775632530a8653acfd9e2dcf90
Reviewed-on: https://chromium-review.googlesource.com/1112009
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569635}
[modify] https://crrev.com/f1a056347fdafc4b51c36d4315f4ba7c0754c05f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Comment 4 by shend@chromium.org, Jun 24 2018

 Issue 855376  has been merged into this issue.
Cc: xingliu@chromium.org
Components: UI>Browser>Downloads
For reference, the tests that were disabled in the CL in #3:

#testFilters
#testUndoDelete
#testUndoDeleteFromMenu
#testUndoDeleteDuplicatesSelected
#testShareOFflinePageWithP2PSharingEnabled

I suspect this may have the same root cause as issue 855219.
Cc: dtrainor@chromium.org
Owner: xingliu@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3de2d33c08d47444e6f7798cea176654e642a5

commit ce3de2d33c08d47444e6f7798cea176654e642a5
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jun 25 18:46:16 2018

Download location: enable flaky tests in DownloadActivityTest.

The CL that causes the flakiness has been reverted. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1112777
Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f.

This CL enables flaky tests in DownloadActivityTest.

TBR=dtrainor@chromium.org

Bug: 855389,855219,855168,855167
Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5
Reviewed-on: https://chromium-review.googlesource.com/1113910
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570107}
[modify] https://crrev.com/ce3de2d33c08d47444e6f7798cea176654e642a5/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Jun 25 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "org.chromium.chrome.browser.download.DownloadActivityTest#testDeleteFiles". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuZG93bmxvYWQuRG93bmxvYWRBY3Rpdml0eVRlc3QjdGVzdERlbGV0ZUZpbGVzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4f6fdc1c619ac1e15ade577008de18525a132e

commit 5d4f6fdc1c619ac1e15ade577008de18525a132e
Author: Theresa <twellington@chromium.org>
Date: Mon Jun 25 22:54:43 2018

Revert "Download location: enable flaky tests in DownloadActivityTest."

This reverts commit ce3de2d33c08d47444e6f7798cea176654e642a5.

Reason for revert: Some of the tests are still failing, triggering a try flakes alert. Will you please re-land with the tests we know are passing conditionally re-enabled?


Original change's description:
> Download location: enable flaky tests in DownloadActivityTest.
> 
> The CL that causes the flakiness has been reverted. See:
> https://chromium-review.googlesource.com/c/chromium/src/+/1112777
> Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f.
> 
> This CL enables flaky tests in DownloadActivityTest.
> 
> TBR=dtrainor@chromium.org
> 
> Bug: 855389,855219,855168,855167
> Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5
> Reviewed-on: https://chromium-review.googlesource.com/1113910
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570107}

TBR=dtrainor@chromium.org,xingliu@chromium.org

Change-Id: I7299f6a85b0acd59050f1f26c0f6c8a8fb3626c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855389, 855219, 855168, 855167
Reviewed-on: https://chromium-review.googlesource.com/1114044
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570215}
[modify] https://crrev.com/5d4f6fdc1c619ac1e15ade577008de18525a132e/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Labels: -sheriff-android
Labels: -Sheriff-Chromium

Sign in to add a comment