Chromad: Esc at the end of Enrollment flow does not restart Chrome |
|||
Issue descriptionWhat steps will reproduce the problem? (1) Enroll device with Active Directory Creds (2) Press ESC at the end of the flow What is the expected result? Chrome restart (similar to when button "done" pressed) What happens instead? Login screen w/o restart
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c7ae8af4959f52f884596557e820b2cdd0bc452 commit 5c7ae8af4959f52f884596557e820b2cdd0bc452 Author: Roman Sorokin <rsorokin@chromium.org> Date: Mon Jul 16 15:59:51 2018 Cros: Fix ESC behaviour for the Enrollment Flow * Restarts Chrome for Active Directory at the end of successful enrollment * ESC not to cancel enrollment during next steps: "license", "attribute-prompt" TEST=manual Bug: 855379 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icaa3dc0f87bfa75c57c8b85c1b410b246fc194e6 Reviewed-on: https://chromium-review.googlesource.com/1118176 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575285} [modify] https://crrev.com/5c7ae8af4959f52f884596557e820b2cdd0bc452/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/5c7ae8af4959f52f884596557e820b2cdd0bc452/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/5c7ae8af4959f52f884596557e820b2cdd0bc452/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
,
Jul 16
,
Jul 18
Verified fixed, ESC at the end of Enrollment flow restarts Chrome: 2018-07-18T21:08:38.596578+00:00 INFO session_manager[1201]: [INFO:policy_store.cc(89)] Persisted policy to disk, path: /var/lib/whitelist/policy.1 2018-07-18T21:08:40.815806+00:00 INFO session_manager[1201]: [INFO:android_oci_wrapper.cc(253)] Cleaning up container 2349 2018-07-18T21:08:40.831801+00:00 INFO session_manager[1201]: [INFO:session_manager_impl.cc(1697)] Android Container with pid 2349 stopped 2018-07-18T21:08:41.057347+00:00 INFO session_manager[1201]: [INFO:child_exit_dispatcher.cc(59)] Handling 1237 exit. 2018-07-18T21:08:41.057417+00:00 INFO session_manager[1201]: [INFO:session_manager_service.cc(297)] Exiting process is chrome. 2018-07-18T21:08:41.057455+00:00 INFO session_manager[1201]: [INFO:browser_job.cc(157)] Terminating process group: Ensuring browser processes are gone. 2018-07-18T21:08:41.057522+00:00 INFO session_manager[1201]: [INFO:system_utils_impl.cc(94)] Sending 9 to -1237 as 1000 Chrome OS: 10888.0.0 Chrome: 69.0.3494.0 Device: Santa Attached authpolicy.log files before and after fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rsorokin@chromium.org
, Jun 28 2018