New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 855338 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jun 2018
Cc:
█ krajshree@chromium.org
kylixrd@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 841643



Sign in to add a comment

New background tab opened from single-tab mode has wrong text color

Project Member Reported by pkasting@chromium.org, Jun 22 2018 
Prerequisite: have a dark window frame such that background tabs should have light text.

Be in single tab mode and middle-click a link to open a new background tab.  The tab title will be dark rather than light.  Presumably, we compute the text color against the single tab mode white frame instead of the standard dark frame.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcdf2cf355180339a1c58433a1f42a40f30e40b2

commit fcdf2cf355180339a1c58433a1f42a40f30e40b2
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jun 29 18:38:08 2018

Fix tab title colors not being recalculated exiting single-tab mode.

When a new tab is added in the background, its title color is calcuated
before single-tab mode is updated, which means it uses a frame color of
white regardless of the actual frame color. This patch fixes that.

This patch also changes Tab::ViewHierarchyChanged to AddedToWidget since
it's more correct and helped me debug.

Bug:  855338 
Change-Id: I007c5f1577260e22265f5c3df877955f3953cfee
Reviewed-on: https://chromium-review.googlesource.com/1119574
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571563}
[modify] https://crrev.com/fcdf2cf355180339a1c58433a1f42a40f30e40b2/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/fcdf2cf355180339a1c58433a1f42a40f30e40b2/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/fcdf2cf355180339a1c58433a1f42a40f30e40b2/chrome/browser/ui/views/tabs/tab_strip.cc

Comment 2 by bsep@chromium.org, Jun 29 2018

Status: Fixed (was: Assigned)

Comment 3 by krajshree@chromium.org, Jul 2

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on win-10 using chrome build without fix as per comment #0. After enabling Mdrefresh at chrome://flags and applying carbon blackout theme, observed that the tab title is lighter rather than dark.

Attaching screen cast of build without fix for reference.

bsep@ - Could you please check the attached screen cast and please let us know if anything missed from our end. Also please provide a sample url or test file to verify the issue from our end.

Thanks...!!
855338@buildwithoutfix.mp4
2.0 MB View Download

Comment 4 by bsep@chromium.org, Jul 2

Labels: -Needs-Feedback
It's not related to themes. Apply a dark accent color by going to Settings > Personalization > Colors and check "Show color on title bar"

Comment 5 by robliao@chromium.org, Jul 12

Labels: Group-Single_Tab_Mode
►

Sign in to add a comment