New issue
Advanced search Search tips

Issue 855330 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Provide thumbnail for download offline content provider

Project Member Reported by shaktisahu@chromium.org, Jun 22 2018

Issue description

This will probably require invoking the thumbnail generator code from native.
We will add caching later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d31574bb5611f23a675f9527d9531d0d475148da

commit d31574bb5611f23a675f9527d9531d0d475148da
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Jun 26 00:07:23 2018

Moved thumbnail generation code from chrome/browser/android to chrome/browser

This will be required for supplying thumbnails to download OfflineContentProvider.
Since the invoking code lives in chrome/browser, we are moving the thumbnail
generation part to platform-independent code as well

Bug: 855330
Change-Id: Ic397e50faa511c83f1241d4c961c5e888ea8d272
Reviewed-on: https://chromium-review.googlesource.com/1111652
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570252}
[modify] https://crrev.com/d31574bb5611f23a675f9527d9531d0d475148da/chrome/browser/BUILD.gn
[modify] https://crrev.com/d31574bb5611f23a675f9527d9531d0d475148da/chrome/browser/android/widget/thumbnail_generator.cc
[modify] https://crrev.com/d31574bb5611f23a675f9527d9531d0d475148da/chrome/browser/android/widget/thumbnail_generator.h
[add] https://crrev.com/d31574bb5611f23a675f9527d9531d0d475148da/chrome/browser/download/image_thumbnail_request.cc
[add] https://crrev.com/d31574bb5611f23a675f9527d9531d0d475148da/chrome/browser/download/image_thumbnail_request.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aa8889ce9a7a2dcfd22e4ebbc2a7f7c4a3677e8

commit 5aa8889ce9a7a2dcfd22e4ebbc2a7f7c4a3677e8
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Jun 29 22:21:39 2018

Downloads OCP : Implemented GetVisualsForItem

Completed the implementation for DownloadsOfflineContentProvider::GetVisualsForItem.

Bug: 855330
Change-Id: If7b9018c7758e3d857b6c34bc709ae517e182e2e
Reviewed-on: https://chromium-review.googlesource.com/1113941
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571674}
[modify] https://crrev.com/5aa8889ce9a7a2dcfd22e4ebbc2a7f7c4a3677e8/chrome/browser/download/download_offline_content_provider.cc
[modify] https://crrev.com/5aa8889ce9a7a2dcfd22e4ebbc2a7f7c4a3677e8/chrome/browser/download/download_offline_content_provider.h

Sign in to add a comment