New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855328 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add flow trace-events for graphics pipeline

Project Member Reported by sadrul@chromium.org, Jun 22 2018

Issue description

Instrument the graphics pipeline with some flow trace-events, so that it's easier to inspect the various stages in the trace-viewer.
 

Comment 1 by sadrul@chromium.org, Jun 22 2018

Cc: rjkroege@chromium.org fsam...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a7940ba6f20565b732e3bb3f225196d79ff6e72

commit 4a7940ba6f20565b732e3bb3f225196d79ff6e72
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jun 22 16:45:14 2018

viz: A helper ctor for BeginFrameAck.

Add a ctor for BeginFrameAck that initializes itself from a
BeginFrameArgs so that it can be used to ack a begin-frame.

BUG=855328
TBR=flackr@ for trivial mechanical blink updates.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I92dd7c2bcb64bc2f29faba83297731996f058ff2
Reviewed-on: https://chromium-review.googlesource.com/1111458
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569657}
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/scheduler/scheduler.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/scheduler/scheduler_unittest.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/common/frame_sinks/begin_frame_args.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/common/frame_sinks/begin_frame_args.h
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/service/display/display_scheduler_unittest.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/components/viz/test/compositor_frame_helpers.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/4a7940ba6f20565b732e3bb3f225196d79ff6e72/third_party/blink/renderer/platform/graphics/video_frame_submitter.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079655db6922b2d9d82572f4d5eecebca0a9bd51

commit 079655db6922b2d9d82572f4d5eecebca0a9bd51
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jun 26 15:16:31 2018

viz: Add trace-id to BeginFrameArgs|Ack.

Add a trace-id to BeginFrameArgs, so that the graphics pipeline can
be instrumented with appropriate flow trace-events, as the begin-frame
flows through the various stages in the graphics pipeline. This first
patch introduces two flow events: one just before the BeginFrameArgs
is first sent to the client, and another when the compositor-frame is
received from the client. Subsequent CLs will add similar trace-events,
both in the client and in the server.

BUG=855328

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2722ff2ce6c710accef83dd0b1c3b9fcf5ce20ac
Reviewed-on: https://chromium-review.googlesource.com/1110672
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570409}
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/components/viz/common/frame_sinks/begin_frame_args.cc
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/components/viz/common/frame_sinks/begin_frame_args.h
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/components/viz/common/frame_sinks/begin_frame_source.h
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/services/viz/public/cpp/compositing/begin_frame_args_struct_traits.cc
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/services/viz/public/cpp/compositing/begin_frame_args_struct_traits.h
[modify] https://crrev.com/079655db6922b2d9d82572f4d5eecebca0a9bd51/services/viz/public/interfaces/compositing/begin_frame_args.mojom

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17

commit b0c6bf3a069b33b247dc7985b2e8400d8ed96d17
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Jun 27 19:39:20 2018

cc/viz: Add some more flow trace-events.

Add some more flow trace-events for the various stages during a frame.
For example:
 . [client] Reception of BeginFrame (ReceiveBeginFrame).
 . [client] Generation of RenderPass, DrawQuad etc (GenerateRenderPass).
 . [client] Generation of CompositorFrame (GenerateCompositorFrame).
 . [client] Submission of CompositorFrame (SubmitCompositorFrame).
 . [server] Aggregation of surfaces from various clients in the
            DisplayCompositor (SurfaceAggregation).

An example screenshot: https://imgur.com/a/ZJGfq2J

BUG=855328

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iccb7b61d485b20256cc8f35a5a4efef4c8ed63ea
Reviewed-on: https://chromium-review.googlesource.com/1116345
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570859}
[modify] https://crrev.com/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/b0c6bf3a069b33b247dc7985b2e8400d8ed96d17/tools/perf/metrics/timeline.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4b7cd215d126758e347e89f771dd5d6db8607c

commit 5f4b7cd215d126758e347e89f771dd5d6db8607c
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jun 29 05:47:56 2018

perf: Fix thread-times/rendering benchmarks.

crrev.com/570859 removed a trace-event that was used to find the frames,
but failed to update the trace-name correctly. This fixes the script so
that frames can correctly be determined again.

BUG=855328

Change-Id: I22980d8473272a256e348b1d3f54e041be51dda1
Reviewed-on: https://chromium-review.googlesource.com/1119625
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571398}
[modify] https://crrev.com/5f4b7cd215d126758e347e89f771dd5d6db8607c/tools/perf/metrics/timeline.py
[modify] https://crrev.com/5f4b7cd215d126758e347e89f771dd5d6db8607c/tools/perf/metrics/timeline_unittest.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/787a378926fb5ce10acf8e27cb2bb715fec07f6e

commit 787a378926fb5ce10acf8e27cb2bb715fec07f6e
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jul 27 10:19:18 2018

rendering: Add pipeline metrics.

Report metrics about the duration of various steps in the compositor
pipeline.

BUG=chromium:855328

Change-Id: Iedd7c3bbf3e64154c58454e86b710f5b395c9909
Reviewed-on: https://chromium-review.googlesource.com/1103792
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

[modify] https://crrev.com/787a378926fb5ce10acf8e27cb2bb715fec07f6e/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/787a378926fb5ce10acf8e27cb2bb715fec07f6e/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14771d4df09bb73a5440b052ea25481bbbdfbe05

commit 14771d4df09bb73a5440b052ea25481bbbdfbe05
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 27 13:27:37 2018

Roll src/third_party/catapult a1e31db3c6b7..787a378926fb (1 commits)

https://chromium.googlesource.com/catapult.git/+log/a1e31db3c6b7..787a378926fb


git log a1e31db3c6b7..787a378926fb --date=short --no-merges --format='%ad %ae %s'
2018-07-27 sadrul@chromium.org rendering: Add pipeline metrics.


Created with:
  gclient setdep -r src/third_party/catapult@787a378926fb

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Ia559efe708fe4426cdbdc09ac7b244abf21dba74
Reviewed-on: https://chromium-review.googlesource.com/1152616
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578618}
[modify] https://crrev.com/14771d4df09bb73a5440b052ea25481bbbdfbe05/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad

commit e05f902a692909dd57b3d3ddbf081c9e1ce2dbad
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Jul 28 14:50:51 2018

Revert "rendering: Add pipeline metrics."

This reverts commit 787a378926fb5ce10acf8e27cb2bb715fec07f6e.

Reason for revert: breaking some stories on rendering benchmarks

BUG: chromium:868648 

Original change's description:
> rendering: Add pipeline metrics.
> 
> Report metrics about the duration of various steps in the compositor
> pipeline.
> 
> BUG=chromium:855328
> 
> Change-Id: Iedd7c3bbf3e64154c58454e86b710f5b395c9909
> Reviewed-on: https://chromium-review.googlesource.com/1103792
> Reviewed-by: Ben Hayden <benjhayden@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

TBR=sadrul@chromium.org,benjhayden@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:855328
Change-Id: I94d9218ed951be336757685c5e8bcaf0a97f5ea3
Reviewed-on: https://chromium-review.googlesource.com/1154367
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/e05f902a692909dd57b3d3ddbf081c9e1ce2dbad/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b409e93988cf47eefe2aed24a93edb81439a19

commit 33b409e93988cf47eefe2aed24a93edb81439a19
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jul 28 16:11:32 2018

Roll src/third_party/catapult 1e61f6096b9a..e05f902a6929 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/1e61f6096b9a..e05f902a6929


git log 1e61f6096b9a..e05f902a6929 --date=short --no-merges --format='%ad %ae %s'
2018-07-28 nednguyen@google.com Revert "rendering: Add pipeline metrics."


Created with:
  gclient setdep -r src/third_party/catapult@e05f902a6929

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: I1ff64230a3aeebfa2a8f3749fd47053320dddcef
Reviewed-on: https://chromium-review.googlesource.com/1154174
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578920}
[modify] https://crrev.com/33b409e93988cf47eefe2aed24a93edb81439a19/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/94294baed844211842477caaa722e58a257e5db3

commit 94294baed844211842477caaa722e58a257e5db3
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jul 31 19:41:41 2018

Reland "rendering: Add pipeline metrics."

Report metrics about the duration of various steps in the compositor
pipeline.

BUG=chromium:855328,  chromium:868648 

Change-Id: I29fb8907bc2d00c8601820c25cb1ffd210d3bac6
Reviewed-on: https://chromium-review.googlesource.com/1156061
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

[modify] https://crrev.com/94294baed844211842477caaa722e58a257e5db3/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/94294baed844211842477caaa722e58a257e5db3/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0723e43e168178f27ebfba6e28420e8f230058d5

commit 0723e43e168178f27ebfba6e28420e8f230058d5
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Tue Jul 31 19:43:50 2018

viz: Additional traces for compositing pipeline.

Add some trace-events for the draw operation, and include breakdown
steps for draw, swap, and wait-for-ack. Link these trace-events from
the surface-aggregation trace-events for various surfaces, so that it
is possible to track all the way from begin-frame to swap-ack (and
later, presentation-time, when we request that for every frame).

BUG=855328

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I319b551a46a0e3f9039ae5250a6b421079cb9b71
Reviewed-on: https://chromium-review.googlesource.com/1153494
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579534}
[modify] https://crrev.com/0723e43e168178f27ebfba6e28420e8f230058d5/components/viz/service/display/display.cc
[modify] https://crrev.com/0723e43e168178f27ebfba6e28420e8f230058d5/components/viz/service/display/display.h
[modify] https://crrev.com/0723e43e168178f27ebfba6e28420e8f230058d5/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/0723e43e168178f27ebfba6e28420e8f230058d5/components/viz/service/display/surface_aggregator.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf136214445b8018d40cc60ea12ad9e80c8cd53

commit 0bf136214445b8018d40cc60ea12ad9e80c8cd53
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 31 23:31:48 2018

Roll src/third_party/catapult 100f0ee2ceb7..44d40fafd233 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/100f0ee2ceb7..44d40fafd233


git log 100f0ee2ceb7..44d40fafd233 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 nednguyen@google.com Improve error message of unhandleable error
2018-07-31 sadrul@chromium.org Reland "rendering: Add pipeline metrics."
2018-07-31 dtu@chromium.org [pinpoint] Don't wrap quest name in status box header.


Created with:
  gclient setdep -r src/third_party/catapult@44d40fafd233

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:869548 ,chromium:855328, chromium:868648 
TBR=sullivan@chromium.org

Change-Id: If13c6ea7fc05a6ae309af1c0de781fc9e558af60
Reviewed-on: https://chromium-review.googlesource.com/1156917
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579619}
[modify] https://crrev.com/0bf136214445b8018d40cc60ea12ad9e80c8cd53/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/5c2d9e757a6f8966612c6be9bb21f6344be00bd8

commit 5c2d9e757a6f8966612c6be9bb21f6344be00bd8
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Aug 01 00:40:11 2018

renderer: Add breakdown metrics for compositor pipeline.

BUG=chromium:855328

Change-Id: Ie52b093bcf0b8c675eaa6d5c2e89e10b1237f44a
Reviewed-on: https://chromium-review.googlesource.com/1153481
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/5c2d9e757a6f8966612c6be9bb21f6344be00bd8/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/5c2d9e757a6f8966612c6be9bb21f6344be00bd8/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7945d0c96bf47fd9713d48df6b669d372acaa5

commit 1a7945d0c96bf47fd9713d48df6b669d372acaa5
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 01 02:44:20 2018

Roll src/third_party/catapult 44d40fafd233..5c2d9e757a6f (1 commits)

https://chromium.googlesource.com/catapult.git/+log/44d40fafd233..5c2d9e757a6f


git log 44d40fafd233..5c2d9e757a6f --date=short --no-merges --format='%ad %ae %s'
2018-08-01 sadrul@chromium.org renderer: Add breakdown metrics for compositor pipeline.


Created with:
  gclient setdep -r src/third_party/catapult@5c2d9e757a6f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Ida622416b7b558f8dc6c5da778f6236a058259a3
Reviewed-on: https://chromium-review.googlesource.com/1157626
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579679}
[modify] https://crrev.com/1a7945d0c96bf47fd9713d48df6b669d372acaa5/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7110f08684550c95683041f07bda8af7bcb636a6

commit 7110f08684550c95683041f07bda8af7bcb636a6
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Aug 02 13:07:47 2018

rendering: Add pipeline:draw in the report.

This reports the time to actually draw the frames. It has breakdowns of
'draw', 'swap', and 'wait for ack' steps.

BUG=chromium:855328

Change-Id: I64083dda2873c22b798eb0ce7e03e86c1cc5994a
Reviewed-on: https://chromium-review.googlesource.com/1158126
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/7110f08684550c95683041f07bda8af7bcb636a6/tracing/tracing/metrics/rendering_metric_test.html
[modify] https://crrev.com/7110f08684550c95683041f07bda8af7bcb636a6/tracing/tracing/metrics/rendering_metric.html

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f0363310dd4fb4eac8c3466676315423234a2ab

commit 7f0363310dd4fb4eac8c3466676315423234a2ab
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 02 17:03:41 2018

Roll src/third_party/catapult 9ac709a1b2a5..7110f0868455 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/9ac709a1b2a5..7110f0868455


git log 9ac709a1b2a5..7110f0868455 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 sadrul@chromium.org rendering: Add pipeline:draw in the report.


Created with:
  gclient setdep -r src/third_party/catapult@7110f0868455

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Iccfd9692ee21b9bf9e96cbdf4a44377c1c1e8918
Reviewed-on: https://chromium-review.googlesource.com/1160781
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580217}
[modify] https://crrev.com/7f0363310dd4fb4eac8c3466676315423234a2ab/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf38395cb75ad19303e30574b8ef038d7ad1570a

commit cf38395cb75ad19303e30574b8ef038d7ad1570a
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Aug 08 15:04:30 2018

viz: Include the 'benchmark' category for some trace events.

The 'viz' category trace-events are not collected by default in
telemetry tests. So add the 'benchmark' category so that these
pipeline-events are visible in telemetry tests.

BUG=855328

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I94a1d4a1046c0d89d2a25e1c5bfe6e01650fc212
Reviewed-on: https://chromium-review.googlesource.com/1165942
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581560}
[modify] https://crrev.com/cf38395cb75ad19303e30574b8ef038d7ad1570a/components/viz/service/display/display.cc

Sign in to add a comment