Bookmark Navigation bar and title issues |
||||||
Issue descriptionSelect > Select Multiple cells > More.. > Move > New Folder Shouldn't be using big titles on the NavController Long Press Cell > Edit Bookmark > Folder (Choose Folder has a buggy top bar)
,
Jun 22 2018
This doesn't seem as important as other bugs; dropping to P3 unless you object
,
Aug 7
The first issue has been solved. The second one needs to be fixed.
,
Aug 10
+martijnb since he originally spotted this.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58d359035fcdf8ef47d26f53ddd56f6db24c4373 commit 58d359035fcdf8ef47d26f53ddd56f6db24c4373 Author: sczs <sczs@chromium.org> Date: Mon Aug 13 16:50:17 2018 [iOS] Fixes Bookmark FolderVC navigationBar background. Previously the Choose Folder Bookmark VC NavigationBar had a gray background. This was caused because the NavigationBar clear background didn't have content under because setEdgesForExtendedLayout was trimming the tableView. This CL also prevents a largeTitle to be displayed whenever this VC is pushed, following the mocks. Bug: 855323 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I45917d2cf467dcd793ac6dfc335e10b4d1ef2eb5 Reviewed-on: https://chromium-review.googlesource.com/1171791 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582614} [modify] https://crrev.com/58d359035fcdf8ef47d26f53ddd56f6db24c4373/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm [modify] https://crrev.com/58d359035fcdf8ef47d26f53ddd56f6db24c4373/ios/chrome/browser/ui/bookmarks/bookmark_folder_view_controller.mm
,
Aug 13
,
Aug 21
Verified in 70.0.3529.0 Canary in iPhone 8plus(iOS 11.4.1), iPad Air(iOS 12 beta 9), iPhone 7 plus(iOS 10.3.3) Bookmark Navigation bar and title looks good, please look at the below recorded video for reference Link to video: https://drive.google.com/file/d/1JYXinDEGm2CjqnLXeOrWdhFN8i48CLa7/view?usp=sharing |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rakurati@chromium.org
, Jun 22 2018