As we are enabling chromevox-arc-native-support by default on ToT, it's difficult to test TalkBack on Arc++ without modifying code on ToT. It would be better to change the flag to 3 values one which can take, enabled, disabled and default.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b51d325c2a6fdc8f7be04d394645da611dd8ccad commit b51d325c2a6fdc8f7be04d394645da611dd8ccad Author: Yuki Awano <yawano@chromium.org> Date: Wed Jul 11 23:45:55 2018 Use three way flag for ChromeVox arc support - Use three way flag for ChromeVox arc support. This allows developers to easily switch between TalkBack on arc and ChromeVox arc support. - This CL also changes default to disabled (TalkBack on arc). Bug: 855310 Test: None Change-Id: I301657798247da20eaf9ad734987b8d40790af1d Reviewed-on: https://chromium-review.googlesource.com/1130963 Commit-Queue: Yuki Awano <yawano@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574411} [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/about_flags.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chromeos/chromeos_features.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chromeos/chromeos_features.h [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chromeos/chromeos_switches.cc [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/chromeos/chromeos_switches.h [modify] https://crrev.com/b51d325c2a6fdc8f7be04d394645da611dd8ccad/tools/metrics/histograms/enums.xml
Comment 1 by yawano@chromium.org
, Jul 9