New issue
Advanced search Search tips

Issue 855308 link

Starred by 2 users
Status: Fixed
Owner:
oksamyt@chromium.org
Closed: Jul 24
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up platform_event_observers_ and related code in RendererBlinkPlatformImpl

Project Member Reported by oksamyt@chromium.org, Jun 22 2018 
Since the Device*EventPump and GamepadSharedMemoryReader classes have been decoupled from PlatformEventObserver, there is no more need for platform_event_observers_ member variable and logic in RendererBlinkPlatformImpl. blink::WebPlatformEventType is no longer used either. This ticket covers removing unused code.

Comment 1 by kojii@chromium.org, Jun 25 2018

Components: -Blink Blink>GamepadAPI

Comment 2 by reillyg@chromium.org, Jun 27 2018

Components: Blink>Sensor>DeviceOrientation
Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by oksamyt@chromium.org, Jul 13

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c47e277ca2dbf13b4bb5e402a7330c29805c04ac

commit c47e277ca2dbf13b4bb5e402a7330c29805c04ac
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Thu Jul 19 05:44:47 2018

Remove platform_event_observers_ from RendererBlinkPlatformImpl

Since platform_event_observers_ is unused, this change removes it and
related code.

Bug:  855308 
Change-Id: I717d8d3676dd4788e2dc27cc2f8d757fac591648
Reviewed-on: https://chromium-review.googlesource.com/1137151
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576384}
[modify] https://crrev.com/c47e277ca2dbf13b4bb5e402a7330c29805c04ac/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/c47e277ca2dbf13b4bb5e402a7330c29805c04ac/content/renderer/renderer_blink_platform_impl.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c352285fa0dfff96c9cc2e440dc7822d6755e9

commit 69c352285fa0dfff96c9cc2e440dc7822d6755e9
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Mon Jul 23 21:14:04 2018

Remove {Start,Stop}Listening methods from Platform classes

This change removes StartListening() and StopListening() methods from
Platform and RendererBlinkPlatformImpl since they are not called
anymore.

Bug:  855308 
Change-Id: I8f240737ca7d37abc1eb3267701f76854742d83d
Reviewed-on: https://chromium-review.googlesource.com/1144224
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577258}
[modify] https://crrev.com/69c352285fa0dfff96c9cc2e440dc7822d6755e9/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/69c352285fa0dfff96c9cc2e440dc7822d6755e9/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/69c352285fa0dfff96c9cc2e440dc7822d6755e9/third_party/blink/public/platform/platform.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86036b4cc513635eaa6186cbe8a154c5cb719543

commit 86036b4cc513635eaa6186cbe8a154c5cb719543
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Tue Jul 24 21:16:02 2018

Remove SampleGamepads() from Platform and RendererBlinkPlatformImpl

The last call of SampleGamepads() was removed from PepperPluginInstanceImpl
since PepperPluginInstanceImpl::Sample() should not be called.

Bug:  855308 
Change-Id: I4c88bd5cbae5ec7413ddf32826486c740690b15f
Reviewed-on: https://chromium-review.googlesource.com/1147612
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577685}
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/content/renderer/render_thread_impl.h
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/86036b4cc513635eaa6186cbe8a154c5cb719543/third_party/blink/public/platform/platform.h

Comment 9 by oksamyt@chromium.org, Jul 24

Status: Fixed (was: Started)
►

Sign in to add a comment