Mac Cocoa for Main Waterfall and CQ |
||||||||||||||||||
Issue descriptionThe desire here is to have a Mac Cocoa bot run on... P1 Main Waterfall P2 CQ To get some test coverage for Cocoa while we set MacViews to default.
,
Jun 22 2018
,
Jun 22 2018
We'd like to get this rolling ASAP. Is there anything I can do to help move this along?
,
Jun 22 2018
TBH, CQ is unlikely given the state of mac capacity these days. #3: nothing specific, but we'll get moving on this soon.
,
Jun 22 2018
I can set up the bot for you, but I don't think I have enough time to do it today. I can try to set it up for you next week. Is that OK?
,
Jun 22 2018
And thanks for offering help to expedite the process. We are still working on docs to self-service setting up the bot, so this time we will set it up for you.
,
Jun 22 2018
Early next week is preferable. Thanks.
,
Jun 22 2018
,
Jun 22 2018
Also, the bot will need to specify --disable-features=ViewsBrowserWindows
,
Jun 22 2018
Any other particular requirements for build or test configuration? I assume we'll want mac_views_browser=false?
,
Jun 22 2018
Oddly enough, mac_views_browser should remain true. Both Cocoa and Views bits ship with Mac. The feature flag chooses which bits actually run.
,
Jun 22 2018
oh really? so the build configuration is the same?
,
Jun 22 2018
I'll also add it shouldn't be necessary to do a special build for this bot. It should be able to consume any binaries built by Mac Builders. The only special consideration is --disable-features=ViewsBrowserWindows needs to be set. Alternatively, fieldtrial_testing_config.json needs to have ViewsBrowserWindows disabled, but IIRC the flag is sufficient for the test.
,
Jun 26 2018
How are we looking on getting this enabled?
,
Jun 26 2018
hzl is out until thursday. I'm trooper this week, so if you need it before then, I can take it.
,
Jun 26 2018
Yep, as requested on #7, we would like this on early this week. Thanks!
,
Jun 26 2018
,
Jun 26 2018
Will get started on it tomorrow AM, then.
,
Jun 26 2018
,
Jun 26 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/80d456710a77f9438db91cecbc9c4928c6966e32 commit 80d456710a77f9438db91cecbc9c4928c6966e32 Author: John Budorick <jbudorick@google.com> Date: Tue Jun 26 22:42:27 2018
,
Jun 26 2018
#20 registered the machine allocated in issue 856395. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1115809 adds recipe & gatekeeper configuration for the bot. I'll add the chromium/src configuration once I've got a clean src checkout, which should be before eod.
,
Jun 26 2018
Are there particular suites you'd like on the bot?
,
Jun 26 2018
... and when you say main waterfall: who do you expect to look at and maintain this bot? chromium sheriffs, or the mac folks?
,
Jun 26 2018
(i.e., should we be setting this up similar to mac-views-rel?)
,
Jun 27 2018
The expectation is that chromium sheriffs will look at this bot. As for test suites, they'll need --disable-features=ViewsBrowserWindows And let's start with... browser_tests and interactive_ui_tests
,
Jun 27 2018
Similar to mac-views-rel would be fine too.
,
Jun 27 2018
(for comparison, mac-views-rel is an FYI bot running far more than just browser_tests and interactive_ui_tests.)
,
Jun 27 2018
Acknowledged. I was scoping it down to the tests that would have the most material change (and thus have the bot run fast and consume fewer resources). If it's easier to go with what mac-views-rel has, let's go with those tests The most important part is the --disable-features=ViewsBrowserWindows portion with the main waterfall.
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337 commit 4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337 Author: John Budorick <jbudorick@chromium.org> Date: Wed Jun 27 23:04:23 2018 LUCI + test configurations for mac-cocoa-rel. Bug: 855301 Change-Id: I2a632402934b865ecc2b87c30262261a0e7d274d Reviewed-on: https://chromium-review.googlesource.com/1117363 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570925} [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/infra/config/global/luci-milo.cfg [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/infra/config/global/luci-scheduler.cfg [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/testing/buildbot/chromium.mac.json [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/testing/buildbot/chromium.memory.json [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/testing/buildbot/test_suites.pyl [modify] https://crrev.com/4d1e0bfc9d6dae1e1ddf97e7ef69d12cfd5a0337/testing/buildbot/waterfalls.pyl
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f commit b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f Author: John Budorick <jbudorick@chromium.org> Date: Wed Jun 27 23:10:44 2018 Recipe configuration for mac-cocoa-rel. Bug: 855301 Change-Id: Ic781592f993d2db63b3c9a027b2ab4fb4e96dc3b Reviewed-on: https://chromium-review.googlesource.com/1115809 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py [modify] https://crrev.com/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f/scripts/slave/gatekeeper.json
,
Jun 28 2018
CI bot is up but appears to be somewhat confused, e.g. from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/15 "browser_tests on (none) GPU on Linux Run on OS: 'Mac-10.13'"
,
Jun 28 2018
It's possible that its a flake.
,
Jun 28 2018
#33: I was referring to the "on Linux" part vs the "Run on OS: 'Mac-10.13'" part :)
,
Jun 28 2018
Ah, fair enough!
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb742256922bbc156167bc63421b8b67053a286c commit eb742256922bbc156167bc63421b8b67053a286c Author: John Budorick <jbudorick@chromium.org> Date: Mon Jul 02 21:36:11 2018 Make mac-cocoa-rel explicitly target 10.13. was implicit previously, leading to the weird "... on Linux" step text on browser_tests. TBR=martiniss@chromium.org Bug: 855301 Change-Id: I06e927a6c60f0d8d296370a756496a73e0aa03b1 Reviewed-on: https://chromium-review.googlesource.com/1121831 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#572006} [modify] https://crrev.com/eb742256922bbc156167bc63421b8b67053a286c/testing/buildbot/chromium.mac.json [modify] https://crrev.com/eb742256922bbc156167bc63421b8b67053a286c/testing/buildbot/waterfalls.pyl
,
Jul 12
,
Jul 12
,
Jul 24
This looks fixed.
,
Jul 25
Still needs a trybot.
,
Jul 25
,
Jul 25
We're approaching the point where we may no longer need a trybot now that MacViews will be shipping for M69. Updating the milestone tags to account for that.
,
Aug 16
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/70b92e71358f24b84fea916f3feffb83036b45a5 commit 70b92e71358f24b84fea916f3feffb83036b45a5 Author: Lindsay Pasricha <lindsayw@google.com> Date: Thu Aug 16 18:17:59 2018
,
Aug 17
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b07abae028e2c1b5512a75458e37de6b09958f7d commit b07abae028e2c1b5512a75458e37de6b09958f7d Author: Lindsay Pasricha <lindsayw@google.com> Date: Fri Aug 17 21:32:47 2018 Add mac-cocoa-rel trybot config Uses the same compile config as gpu_tests_release_trybot. Bug: 855301 Change-Id: I70947b3bd21cbbe0519dcb37cb8c6bf844a3e274 Reviewed-on: https://chromium-review.googlesource.com/1179988 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584199} [modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/infra/config/global/luci-milo.cfg [modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/tools/mb/mb_config.pyl
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d6ce33215fef21953f56abcbf89e2727dacc2b00 commit d6ce33215fef21953f56abcbf89e2727dacc2b00 Author: Lindsay Pasricha <lindsayw@google.com> Date: Fri Aug 17 21:49:51 2018 Add mac-cocoa-rel trybot config in tryserver.chromium.mac Bug:855301 Change-Id: Ia242f3e882df69b197a0b1dd23b3fa5085193a8f Reviewed-on: https://chromium-review.googlesource.com/1180286 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> [modify] https://crrev.com/d6ce33215fef21953f56abcbf89e2727dacc2b00/tests/masters_recipes_test.py [modify] https://crrev.com/d6ce33215fef21953f56abcbf89e2727dacc2b00/scripts/slave/recipe_modules/chromium_tests/trybots.py
,
Aug 20
Trybot is up and running. That completes the ticket
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73dabd9844e91bf6585bc65ae17cefc8d54df3c3 commit 73dabd9844e91bf6585bc65ae17cefc8d54df3c3 Author: Yiming Zhou <uwyiming@google.com> Date: Tue Dec 11 00:04:46 2018 Add autofill bots to cr-buildbucket. Bug: 855301 Change-Id: I1b20b18ff37742abc70387ce8ce469eedf24e4bb Reviewed-on: https://chromium-review.googlesource.com/c/1370910 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#615338} [modify] https://crrev.com/73dabd9844e91bf6585bc65ae17cefc8d54df3c3/infra/config/global/cr-buildbucket.cfg |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by hzl@chromium.org
, Jun 22 2018Labels: -Type-Bug Type-Feature