New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855301 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
M-X

Blocked on:
issue 856395
issue 867610

Blocking:
issue 854267



Sign in to add a comment

Mac Cocoa for Main Waterfall and CQ

Project Member Reported by robliao@chromium.org, Jun 22 2018

Issue description

The desire here is to have a Mac Cocoa bot run on...

P1 Main Waterfall
P2 CQ

To get some test coverage for Cocoa while we set MacViews to default.
 

Comment 1 by hzl@chromium.org, Jun 22 2018

Cc: jbudorick@chromium.org
Labels: -Type-Bug Type-Feature

Comment 2 by hzl@chromium.org, Jun 22 2018

Status: Available (was: Untriaged)
Labels: M-69 Proj-MacViews Target-69
We'd like to get this rolling ASAP. Is there anything I can do to help move this along?
Status: Untriaged (was: Available)
TBH, CQ is unlikely given the state of mac capacity these days.

#3: nothing specific, but we'll get moving on this soon.

Comment 5 by h...@google.com, Jun 22 2018

I can set up the bot for you, but I don't think I have enough time to do it today. I can try to set it up for you next week. Is that OK?

Comment 6 by h...@google.com, Jun 22 2018

And thanks for offering help to expedite the process. We are still working on docs to self-service setting up the bot, so this time we will set it up for you.
Early next week is preferable. Thanks.
Owner: hzl@chromium.org
Status: Assigned (was: Untriaged)
Also, the bot will need to specify

--disable-features=ViewsBrowserWindows
Any other particular requirements for build or test configuration? I assume we'll want mac_views_browser=false?
Oddly enough, mac_views_browser should remain true.

Both Cocoa and Views bits ship with Mac. The feature flag chooses which bits actually run.
oh really? so the build configuration is the same?
I'll also add it shouldn't be necessary to do a special build for this bot. It should be able to consume any binaries built by Mac Builders. The only special consideration is --disable-features=ViewsBrowserWindows needs to be set.

Alternatively, fieldtrial_testing_config.json needs to have ViewsBrowserWindows disabled, but IIRC the flag is sufficient for the test.
How are we looking on getting this enabled?
hzl is out until thursday. I'm trooper this week, so if you need it before then, I can take it.
Yep, as requested on #7, we would like this on early this week. Thanks!
Owner: jbudorick@chromium.org
Cc: -jbudorick@chromium.org hzl@chromium.org
Will get started on it tomorrow AM, then.
Blockedon: 856395
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/80d456710a77f9438db91cecbc9c4928c6966e32

commit 80d456710a77f9438db91cecbc9c4928c6966e32
Author: John Budorick <jbudorick@google.com>
Date: Tue Jun 26 22:42:27 2018

Status: Started (was: Assigned)
#20 registered the machine allocated in issue 856395. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1115809 adds recipe & gatekeeper configuration for the bot. I'll add the chromium/src configuration once I've got a clean src checkout, which should be before eod.
Are there particular suites you'd like on the bot?
... and when you say main waterfall: who do you expect to look at and maintain this bot? chromium sheriffs, or the mac folks?
(i.e., should we be setting this up similar to mac-views-rel?)
The expectation is that chromium sheriffs will look at this bot. 

As for test suites, they'll need
--disable-features=ViewsBrowserWindows

And let's start with...
browser_tests
and
interactive_ui_tests
Similar to mac-views-rel would be fine too.
(for comparison, mac-views-rel is an FYI bot running far more than just browser_tests and interactive_ui_tests.)
Acknowledged. I was scoping it down to the tests that would have the most material change (and thus have the bot run fast and consume fewer resources). If it's easier to go with what mac-views-rel has, let's go with those tests

The most important part is the --disable-features=ViewsBrowserWindows portion with the main waterfall.
Cc: linds...@chromium.org
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 27 2018

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f

commit b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Jun 27 23:10:44 2018

Recipe configuration for mac-cocoa-rel.

Bug:  855301 
Change-Id: Ic781592f993d2db63b3c9a027b2ab4fb4e96dc3b
Reviewed-on: https://chromium-review.googlesource.com/1115809
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py
[modify] https://crrev.com/b3550b9f0d00c5dca2f4d07f4ef5f0f153801b3f/scripts/slave/gatekeeper.json

CI bot is up but appears to be somewhat confused, e.g. from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/15

"browser_tests on (none) GPU on Linux Run on OS: 'Mac-10.13'"
It's possible that its a flake.
#33: I was referring to the "on Linux" part vs the "Run on OS: 'Mac-10.13'" part :)
Ah, fair enough!
Project Member

Comment 36 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb742256922bbc156167bc63421b8b67053a286c

commit eb742256922bbc156167bc63421b8b67053a286c
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Jul 02 21:36:11 2018

Make mac-cocoa-rel explicitly target 10.13.

was implicit previously, leading to the weird "... on Linux" step
text on browser_tests.

TBR=martiniss@chromium.org

Bug:  855301 
Change-Id: I06e927a6c60f0d8d296370a756496a73e0aa03b1
Reviewed-on: https://chromium-review.googlesource.com/1121831
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572006}
[modify] https://crrev.com/eb742256922bbc156167bc63421b8b67053a286c/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/eb742256922bbc156167bc63421b8b67053a286c/testing/buildbot/waterfalls.pyl

Labels: -M-69 Group-Feature_Process
Labels: M-69
Status: Fixed (was: Started)
This looks fixed.
Status: Assigned (was: Fixed)
Still needs a trybot.
Blockedon: 867610
Labels: -M-69 -Target-69 M-X
We're approaching the point where we may no longer need a trybot now that MacViews will be shipping for M69.

Updating the milestone tags to account for that.
Project Member

Comment 43 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/70b92e71358f24b84fea916f3feffb83036b45a5

commit 70b92e71358f24b84fea916f3feffb83036b45a5
Author: Lindsay Pasricha <lindsayw@google.com>
Date: Thu Aug 16 18:17:59 2018

Cc: jbudorick@chromium.org
Owner: linds...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 45 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b07abae028e2c1b5512a75458e37de6b09958f7d

commit b07abae028e2c1b5512a75458e37de6b09958f7d
Author: Lindsay Pasricha <lindsayw@google.com>
Date: Fri Aug 17 21:32:47 2018

Add mac-cocoa-rel trybot config

Uses the same compile config as gpu_tests_release_trybot.

Bug:  855301 
Change-Id: I70947b3bd21cbbe0519dcb37cb8c6bf844a3e274
Reviewed-on: https://chromium-review.googlesource.com/1179988
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584199}
[modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/b07abae028e2c1b5512a75458e37de6b09958f7d/tools/mb/mb_config.pyl

Project Member

Comment 46 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d6ce33215fef21953f56abcbf89e2727dacc2b00

commit d6ce33215fef21953f56abcbf89e2727dacc2b00
Author: Lindsay Pasricha <lindsayw@google.com>
Date: Fri Aug 17 21:49:51 2018

Add mac-cocoa-rel trybot config in tryserver.chromium.mac

Bug:855301
Change-Id: Ia242f3e882df69b197a0b1dd23b3fa5085193a8f
Reviewed-on: https://chromium-review.googlesource.com/1180286
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>

[modify] https://crrev.com/d6ce33215fef21953f56abcbf89e2727dacc2b00/tests/masters_recipes_test.py
[modify] https://crrev.com/d6ce33215fef21953f56abcbf89e2727dacc2b00/scripts/slave/recipe_modules/chromium_tests/trybots.py

Status: Fixed (was: Started)
Trybot is up and running. That completes the ticket
Project Member

Comment 48 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73dabd9844e91bf6585bc65ae17cefc8d54df3c3

commit 73dabd9844e91bf6585bc65ae17cefc8d54df3c3
Author: Yiming Zhou <uwyiming@google.com>
Date: Tue Dec 11 00:04:46 2018

Add autofill bots to cr-buildbucket.

Bug:  855301 
Change-Id: I1b20b18ff37742abc70387ce8ce469eedf24e4bb
Reviewed-on: https://chromium-review.googlesource.com/c/1370910
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Cr-Commit-Position: refs/heads/master@{#615338}
[modify] https://crrev.com/73dabd9844e91bf6585bc65ae17cefc8d54df3c3/infra/config/global/cr-buildbucket.cfg

Sign in to add a comment