New issue
Advanced search Search tips

Issue 855292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

border image layout tests fail with OOP-R

Project Member Reported by enne@chromium.org, Jun 22 2018

Issue description

These three layout tests fail with OOP-R turned on (and do not fail with GPU raster turned on, such as in issue 809807):

 css3/background/background-border-image-auto-margins.html
 svg/as-border-image/svg-as-border-image-2.html
 svg/as-border-image/svg-as-border-image.html

 
background-border-image-auto-margins-actual.png
2.8 KB View Download
background-border-image-auto-margins-expected.png
2.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4bdc13e7795add33373622ac7ea5ac298dd026d

commit c4bdc13e7795add33373622ac7ea5ac298dd026d
Author: Adrienne Walker <enne@chromium.org>
Date: Wed Jun 27 00:56:30 2018

cc: Fix OOP-R PaintShader tile offset bug

Converting to a fixed scale PaintShader needs to take into account the
offset in the tile rect.  Previously, this was getting dropped.  It
needs to be scaled, and then subtracted from the picture that we replay
into.

Bug:  855292 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icac412c29540c5c453dbd642567de2dda3b97523
Reviewed-on: https://chromium-review.googlesource.com/1115958
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570601}
[modify] https://crrev.com/c4bdc13e7795add33373622ac7ea5ac298dd026d/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/c4bdc13e7795add33373622ac7ea5ac298dd026d/cc/paint/paint_shader.cc
[modify] https://crrev.com/c4bdc13e7795add33373622ac7ea5ac298dd026d/cc/test/paint_op_helper.h

Comment 2 by enne@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment