New issue
Advanced search Search tips

Issue 855286 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 841643



Sign in to add a comment

Disable single-tab mode when your only tab is pinned

Project Member Reported by bsep@chromium.org, Jun 22 2018 
We could instead always show the pinned tab's title in single-tab mode, but that's a more complicated change and could lead to people thinking the tab pinning is broken. Plus the user is probably going to add more tabs to the window anyway; otherwise there's not much point in having a pinned tab.

Comment 1 by pkasting@chromium.org, Jun 22 2018

Blocking: 841643
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40

commit 57b12e0a1bf6bfdd31152e59393491ae7ca6fd40
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Jun 26 01:33:37 2018

Refresh: disallow single-tab mode when the only tab is pinned.

Bug:  855286 
Change-Id: I35b3fcce765c41f7b845ec3e5ec7924750b8a1c2
Reviewed-on: https://chromium-review.googlesource.com/1114334
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570287}
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/tab_strip_observer.cc
[modify] https://crrev.com/57b12e0a1bf6bfdd31152e59393491ae7ca6fd40/chrome/browser/ui/views/tabs/tab_strip_observer.h

Comment 3 by bsep@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment