WebView layout tests failing on L, M, and N testers due to changed webview interfaces |
||||||
Issue descriptionC 164.486s Main [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces: C 164.486s Main org.junit.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[interface ShadowRoot : DocumentFragment.getter pictureInPictureElement C 164.486s Main interface Document : Node.method exitPictureInPicture C 164.486s Main interface Document : Node.getter pictureInPictureEnabled C 164.486s Main interface Document : Node.getter pictureInPictureElement C 164.486s Main interface PictureInPictureWindow : EventTarget C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.getter onenterpictureinpicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.getter onleavepictureinpicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.setter onleavepictureinpicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.method requestPictureInPicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.setter disablePictureInPicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.getter disablePictureInPicture C 164.486s Main interface HTMLVideoElement : HTMLMediaElement.setter onenterpictureinpicture C 164.486s Main ]> C 164.486s Main at org.junit.Assert.assertEquals(Assert.java:115) C 164.486s Main at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:237) C 164.486s Main at java.lang.reflect.Method.invoke(Native Method) C 164.486s Main at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) C 164.486s Main at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) C 164.486s Main at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) C 164.486s Main at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) C 164.486s Main at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) C 164.486s Main at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) C 164.486s Main at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) C 164.486s Main at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) C 164.486s Main at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) C 164.486s Main at org.junit.rules.RunRules.evaluate(RunRules.java:20) C 164.486s Main at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) C 164.486s Main at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) C 164.486s Main at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237) C 164.486s Main at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48) C 164.486s Main at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) C 164.486s Main at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) C 164.486s Main at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) C 164.486s Main at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) C 164.486s Main at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) C 164.486s Main at org.junit.runners.ParentRunner.run(ParentRunner.java:363) C 164.486s Main at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220) C 164.486s Main at org.junit.runners.Suite.runChild(Suite.java:128) C 164.486s Main at org.junit.runners.Suite.runChild(Suite.java:27) C 164.487s Main at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) C 164.487s Main at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) C 164.487s Main at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) C 164.487s Main at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) C 164.487s Main at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) C 164.487s Main at org.junit.runners.ParentRunner.run(ParentRunner.java:363) C 164.487s Main at org.junit.runner.JUnitCore.run(JUnitCore.java:137) C 164.487s Main at org.junit.runner.JUnitCore.run(JUnitCore.java:115) C 164.487s Main at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) C 164.487s Main at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) C 164.487s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Was this interface intended for Android, if so, please update the expected interfaces. suspected culprit: https://chromium-review.googlesource.com/1090728 assigning to reviewer.
,
Jun 22 2018
,
Jun 23 2018
I'm the one who intentionally did not provide any exceptions for Android (and Web View) as I thought stable interfaces would not be tested on these platforms. mlamouri@ do you know where I could add some exceptions for WebView?
,
Jun 23 2018
WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1112247
,
Jun 25 2018
,
Jun 25 2018
Friendly sheriff ping - any updates here?
,
Jun 25 2018
François is working on a fix.
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d94396277cd8943c8044bd7c04cfb6b98f2bf930 commit d94396277cd8943c8044bd7c04cfb6b98f2bf930 Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Jun 26 09:11:11 2018 Don't expose Picture-in-Picture API for Android WebView. Picture-in-Picture API is disabled in Android WebView as there is no UI implemented. Bug: 855270 , 852449 Change-Id: Id7c0ebcc94085f6e1b3f00383254780a5357269b Reviewed-on: https://chromium-review.googlesource.com/1112247 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#570352} [modify] https://crrev.com/d94396277cd8943c8044bd7c04cfb6b98f2bf930/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
,
Jun 26 2018
,
Jun 26 2018
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20L%20(dbg)/1215 still fails but for another reason "interface RTCDTMFSender : EventTarget.getter duration" unrelated to Picture-in-Picture.
,
Jun 26 2018
I've created a separate bug 856643 for the problem mentioned in c#10 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aluo@chromium.org
, Jun 21 2018