New issue
Advanced search Search tips

Issue 855268 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jun 2018
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSS: text-indent should serialize in canonical order

Project Member Reported by ericwilligers@chromium.org, Jun 21 2018 
text-indent values such as "each-line calc(2em + 3ex)"
and "each-line hanging -5vh" should parse successfully
but serialize in canonical order: <length-percentage> hanging? each-line? 

We currently preserve the order supplied by the page author.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/742dc34b658e6e61946fca4d0fa4a4d2103b81e9

commit 742dc34b658e6e61946fca4d0fa4a4d2103b81e9
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Sat Jun 23 22:46:10 2018

CSS: text-indent serializes in canonical order

text-indent values such as "each-line calc(2em + 3ex)"
and "each-line hanging -5vh" now parse successfully
and serialize in canonical order: <length-percentage> hanging? each-line?

Spec:
https://drafts.csswg.org/css-text-3/#text-indent-property

BUG= 855268 

Change-Id: I17fece32135140637880a47303062fa8b23c291c
Reviewed-on: https://chromium-review.googlesource.com/1111177
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569908}
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/animations/responsive/animations-responsive-textIndent.html
[add] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/css-parser/text-indent-valid.html
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/WebKit/LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js
[modify] https://crrev.com/742dc34b658e6e61946fca4d0fa4a4d2103b81e9/third_party/blink/renderer/core/css/properties/longhands/text_indent_custom.cc

Comment 2 by ericwilligers@chromium.org, Jun 24 2018

Status: Fixed (was: Started)
►

Sign in to add a comment