OobeDisplayChooser in oobe_display_chooser.cc calls: ash::Shell::Get()->window_tree_host_manager()->SetPrimaryDisplayId() This can be replaced with a call to cros_display_config.mojom.SetDisplayProperties(id, {set_primary = true});
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3985dbe070befccab23722bbf0110b6887ee1d8c commit 3985dbe070befccab23722bbf0110b6887ee1d8c Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 25 23:10:00 2018 Pass an explicit throttle bool to DisplayConfigurationController CrosDisplayConfig uses DisplayConfigurationController for many of its operations. Two of those impose rate limiting, which is unexpected and problematic for client operations that expect to always succeed. The rate limiting was added for accelerators (accelerator_controller.cc) which does not have a straightforward way to do rate limiting, so this CL adds a |throttle| boolean to pass to rate limited operations. Currently the throttling is not impacting any use of CrosDisplayConfig, but crbug.com/855251 requires this change in order to be able to use the mojo API reliably during startup. Bug: 855251 Change-Id: Ied3f259bfbde566c7575ddc6d3ef3d3958e956b1 Reviewed-on: https://chromium-review.googlesource.com/1112748 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570223} [modify] https://crrev.com/3985dbe070befccab23722bbf0110b6887ee1d8c/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/3985dbe070befccab23722bbf0110b6887ee1d8c/ash/display/cros_display_config.cc [modify] https://crrev.com/3985dbe070befccab23722bbf0110b6887ee1d8c/ash/display/display_configuration_controller.cc [modify] https://crrev.com/3985dbe070befccab23722bbf0110b6887ee1d8c/ash/display/display_configuration_controller.h [modify] https://crrev.com/3985dbe070befccab23722bbf0110b6887ee1d8c/ash/display/display_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfb42c2cac4f50ff304e047f3fa8e784963a175c commit dfb42c2cac4f50ff304e047f3fa8e784963a175c Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jun 27 17:49:51 2018 Use cros_display_config.mojom in OobeDisplayChooser Bug: 855251 Change-Id: Ic751c558b5f8ecb5a8334e2c5499ad9e1bbcf80e Reviewed-on: https://chromium-review.googlesource.com/1112759 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570831} [modify] https://crrev.com/dfb42c2cac4f50ff304e047f3fa8e784963a175c/chrome/browser/ui/webui/chromeos/login/DEPS [modify] https://crrev.com/dfb42c2cac4f50ff304e047f3fa8e784963a175c/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc [modify] https://crrev.com/dfb42c2cac4f50ff304e047f3fa8e784963a175c/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.h [modify] https://crrev.com/dfb42c2cac4f50ff304e047f3fa8e784963a175c/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc [modify] https://crrev.com/dfb42c2cac4f50ff304e047f3fa8e784963a175c/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f6b42f57ec498540b43cc60c892b64d134d14a8 commit 8f6b42f57ec498540b43cc60c892b64d134d14a8 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jul 02 16:44:51 2018 Replace ash::Shell display_manager calls in core_oobe_handler.cc This is used by getPrimaryDisplayNameForTesting which is called from the CrOS autotest enterprise_RemoraRequisitionDisplayUsage.py. Includes a TODO to update the autotest to call the equivalent extension API. If this breaks enterprise_RemoraRequisitionDisplayUsage, please revert. Bug: 855251 Change-Id: I73007ba2a4d4a20c46da940f59fe98353cabf294 Reviewed-on: https://chromium-review.googlesource.com/1114295 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571923} [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/ash/ash_util.h [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/webui/chromeos/login/DEPS [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/8f6b42f57ec498540b43cc60c892b64d134d14a8/chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc
Comment 1 by bugdroid1@chromium.org
, Jun 25 2018