New issue
Advanced search Search tips

Issue 855247 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-02
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 923301


Previous locations:
gerrit:9331


Sign in to add a comment

TryJobs do not appear in Firefox, Safari, Edge and IE

Project Member Reported by rafael.c...@microsoft.com, Jun 21 2018

Issue description

Affected Version: 2.15.2-4227-g1c1adca9c7

What steps will reproduce the problem?
1. Open https://chromium-review.googlesource.com/c/angle/angle/+/1109396 or similar PR in Edge or Firefox 
2. Scroll down past the list of files

What is the expected output?
Try jobs for various patch lists display like it does in Chrome

What do you see instead?
Text that says "No Tryjobs Showing jobs from patch set 4, Last updated at "
 

Comment 1 by kaspern@google.com, Jun 21 2018

Project: chromium
Moved issue gerrit:9331 to now be issue chromium:855247.
Components: Infra>Platform>Buildbucket>Gerrit
On Firefox, I am seeing "Loading Tryjobs..." forever, and the try jobs fail to load. Digging into the issue, it appears to be due to the CORS configuration. Firefox reports "missing token ‘user-agent’ in CORS header ‘Access-Control-Allow-Headers’ from CORS preflight channel". Looking at the response headers, the header is set to "Origin, Authorization, Content-Type, Accept", which is indeed lacking "User-Agent". Chrome allows the request anyway (and still seems to set the user-agent header?), but Firefox blocks it.
Cc: rkjnsn@chromium.org
Owner: no...@chromium.org
Status: Started (was: New)
thanks for analysis! https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/1370789/
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/61769122f33a49c992ae35e69bdfe27dccf3218e

commit 61769122f33a49c992ae35e69bdfe27dccf3218e
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Dec 11 18:31:42 2018

[endpoints_webapp2] Allow User-Agent in CORS

Allow User-Agent request header in CORS requests.

R=vadimsh@chromium.org

Bug: 855247
Change-Id: Ie8bc27d2f51672c02425290d47da3b54f658de9d
Reviewed-on: https://chromium-review.googlesource.com/c/1370789
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/61769122f33a49c992ae35e69bdfe27dccf3218e/appengine/components/components/endpoints_webapp2/adapter.py

Labels: Pri-2 Type-Bug
NextAction: 2019-01-02
update: the plugin is currently completely broken in Firefox because of an unrelated rollout on gerrit side. The fix is ready, but i cannot deploy it until prod unfreeze (jan 2)
The NextAction date has arrived: 2019-01-02
deployment started. It will take a few days.
update: the CORS was issue was resolved, but there are other tryjobs still do not appear for a different reason. It is unclear why, I will ask for polymer expertise through internal channels.
Summary: TryJobs do not appear in Firefox, Safari, Edge and IE (was: TryJobs do not appear in Firefox, Edge and IE)
Blockedon: gerrit:10291
looks like this broke for all plugins

Sign in to add a comment