The change in crbug.com/818242 may result in redundant language being added |
||||
Issue descriptionChrome Version: 69+ (Canary) OS: any What steps will reproduce the problem? (1) Make sure your UI language is EN-US or any other language with a locale attached to it. (2) Change target language to one not in chrome://language-settings. (3) Observe that the target language got correctly added to chrome://language-settings. (4) Now remove the language that just got added from chrome://language-settings. (5) Go back to the translated page and translate again. Observe that the target language correctly switches back to English (6) Go back to chrome://language-settings. English has been added to the bottom of the list. What is the expected result? Since English is already in the list as EN-US, don't add EN. What happens instead? Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 16
,
Aug 16
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0accc8b963acbe34c0d542d52b8d57b85cc7b192 commit 0accc8b963acbe34c0d542d52b8d57b85cc7b192 Author: Alexandre Frechette <frechette@chromium.org> Date: Fri Aug 31 19:16:05 2018 [Language] Avoid adding redundant target language to chrome://settings/languages Bug: 855244 Change-Id: Ia52d8a7e6ebacd1d3882e16685e4dcdc95f31694 Reviewed-on: https://chromium-review.googlesource.com/1176344 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#588111} [modify] https://crrev.com/0accc8b963acbe34c0d542d52b8d57b85cc7b192/components/language/core/common/locale_util.cc [modify] https://crrev.com/0accc8b963acbe34c0d542d52b8d57b85cc7b192/components/language/core/common/locale_util.h [modify] https://crrev.com/0accc8b963acbe34c0d542d52b8d57b85cc7b192/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/0accc8b963acbe34c0d542d52b8d57b85cc7b192/components/translate/core/browser/translate_manager_unittest.cc
,
Sep 10
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yyushkina@chromium.org
, Jun 28 2018