New issue
Advanced search Search tips

Issue 855242 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 822474



Sign in to add a comment

Add support for multi-package deployments

Project Member Reported by kmarshall@chromium.org, Jun 21 2018

Issue description

Refactor scripts & GN rules to automatically deploy and run solutions which span multiple packages.
 
Summary: Add support for multi-package deployments (was: Add support multi-package deployments)
Blocking: 822474
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39b4aa89414e455dca9b5da218d277e1b9d32929

commit 39b4aa89414e455dca9b5da218d277e1b9d32929
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Jun 23 00:12:15 2018

Fuchsia: Break apart package & script gen into separate GN rules.

This is a prerequisite step toward supporting multi-package
deployments.

* Replaces all calls to fuchsia_executable_runner() with
package and script generation targets. The revised rules are
simple enough that fuchsia_executable_runner() is no longer a
major convenience.
* Delete test_runner_script() for the same reasons.
* Use sensible defaults for things like sandbox_policy to clean
up the parameters for most instances of the rules.

Bug: 	 855242 
Change-Id: I2f04e1baa9afaf24cfd5d979d33e9912a0475e55
Reviewed-on: https://chromium-review.googlesource.com/1110749
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569850}
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/BUILD.gn
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/build/config/fuchsia/package.gni
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/build/config/fuchsia/rules.gni
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/build/fuchsia/layout_test_proxy/BUILD.gn
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/chromecast/BUILD.gn
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/content/shell/BUILD.gn
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/headless/BUILD.gn
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/testing/test.gni
[modify] https://crrev.com/39b4aa89414e455dca9b5da218d277e1b9d32929/webrunner/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63246bad6f9994a98c737eab87738abed2927c1

commit b63246bad6f9994a98c737eab87738abed2927c1
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Jun 23 22:45:10 2018

Fuchsia: Add support for package dependencies to fuchsia_package_runner.

fuchsia_package_runner() targets can now specify multiple packages for
deployment, using the "package_deps" argument.

Bug:  855242 
Change-Id: Ib9bb67be14d6b120ea2bf008edd2941d14c36e46
Reviewed-on: https://chromium-review.googlesource.com/1111274
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569907}
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/config/fuchsia/rules.gni
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/fuchsia/common_args.py
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/fuchsia/create_runner_script.py
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/fuchsia/exe_runner.py
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/fuchsia/run_package.py
[modify] https://crrev.com/b63246bad6f9994a98c737eab87738abed2927c1/build/fuchsia/test_runner.py

Status: Verified (was: Assigned)

Sign in to add a comment