"org.chromium.chrome.browser.download.DownloadActivityTest#testDeleteFileFromMenu" is flaky |
||||||
Issue description"org.chromium.chrome.browser.download.DownloadActivityTest#testDeleteFileFromMenu" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 23 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuZG93bmxvYWQuRG93bmxvYWRBY3Rpdml0eVRlc3QjdGVzdERlbGV0ZUZpbGVGcm9tTWVudQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055aafbe751ade39703914fc746ceb137543ce62 commit 055aafbe751ade39703914fc746ceb137543ce62 Author: Darren Shen <shend@chromium.org> Date: Fri Jun 22 03:37:50 2018 Disable flaky chrome.browser.download.DownloadActivityTest tests TBR=dtrainor@chromium.org Bug: 855219, 855168, 855167, 854241 Change-Id: I555f125d6d581e4f7d0361e61bc6a3d2963d37a1 Reviewed-on: https://chromium-review.googlesource.com/1111483 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569525} [modify] https://crrev.com/055aafbe751ade39703914fc746ceb137543ce62/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
,
Jun 22 2018
,
Jun 25 2018
Tests disabled in the CL in #2 for reference: #testSpaceDisplay #testDeleteFiles #testDeleteFileFromMenu #testShareFiles #testSpaceDisplay example failure: https://ci.chromium.org/buildbot/chromium.swarm/Android%20N5X%20Swarm/7961 From the logcat: 06-21 06:46:46.024 5796 5796 D StrictMode: StrictMode policy violation; ~duration=3 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=6094879 violation=2 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1263) 06-21 06:46:46.024 5796 5796 D StrictMode: at libcore.io.BlockGuardOs.statvfs(BlockGuardOs.java:297) 06-21 06:46:46.024 5796 5796 D StrictMode: at java.io.File.getTotalSpace(File.java:1126) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.storage.StorageManager.getStorageLowBytes(StorageManager.java:943) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.storage.VolumeInfo.buildStorageVolume(VolumeInfo.java:362) 06-21 06:46:46.024 5796 5796 D StrictMode: at com.android.server.MountService.getVolumeList(MountService.java:2712) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.storage.IMountService$Stub.onTransact(IMountService.java:1648) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Binder.execTransact(Binder.java:453) 06-21 06:46:46.024 5796 5796 D StrictMode: # via Binder call with stack: 06-21 06:46:46.024 5796 5796 D StrictMode: android.os.StrictMode$LogStackTrace 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.StrictMode.readAndHandleBinderCallViolations(StrictMode.java:1911) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Parcel.readExceptionCode(Parcel.java:1601) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Parcel.readException(Parcel.java:1570) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.storage.IMountService$Stub$Proxy.getVolumeList(IMountService.java:772) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.storage.StorageManager.getVolumeList(StorageManager.java:883) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Environment$UserEnvironment.getExternalDirs(Environment.java:83) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Environment.getExternalStorageDirectory(Environment.java:340) 06-21 06:46:46.024 5796 5796 D StrictMode: at org.chromium.chrome.browser.download.DownloadManagerService$4.onPostExecute(DownloadManagerService.java:1549) 06-21 06:46:46.024 5796 5796 D StrictMode: at org.chromium.chrome.browser.download.DownloadManagerService$4.onPostExecute(DownloadManagerService.java:1544) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.AsyncTask.finish(AsyncTask.java:651) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.AsyncTask.-wrap1(AsyncTask.java) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:668) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Handler.dispatchMessage(Handler.java:102) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.os.Looper.loop(Looper.java:148) 06-21 06:46:46.024 5796 5796 D StrictMode: at android.app.ActivityThread.main(ActivityThread.java:5417) 06-21 06:46:46.024 5796 5796 D StrictMode: at java.lang.reflect.Method.invoke(Method.java) 06-21 06:46:46.024 5796 5796 D StrictMode: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) 06-21 06:46:46.024 5796 5796 D StrictMode: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) +xingliu@ - could these have the same root cause as the CL you reverted Saturday? https://chromium.googlesource.com/chromium/src/+/e4144ed1a4845edb13e3afce024a8cb60588b38f
,
Jun 25 2018
Yes, the reverted CL should fix this, I didn't check yet.
,
Jun 25 2018
,
Jun 25 2018
Will enable these tests soon, since the root cause CL has been reverted.
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce3de2d33c08d47444e6f7798cea176654e642a5 commit ce3de2d33c08d47444e6f7798cea176654e642a5 Author: Xing Liu <xingliu@chromium.org> Date: Mon Jun 25 18:46:16 2018 Download location: enable flaky tests in DownloadActivityTest. The CL that causes the flakiness has been reverted. See: https://chromium-review.googlesource.com/c/chromium/src/+/1112777 Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f. This CL enables flaky tests in DownloadActivityTest. TBR=dtrainor@chromium.org Bug: 855389,855219,855168,855167 Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5 Reviewed-on: https://chromium-review.googlesource.com/1113910 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570107} [modify] https://crrev.com/ce3de2d33c08d47444e6f7798cea176654e642a5/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
,
Jun 25 2018
It looks like some of these tests are still experiencing errors, e.g. DownloadActivityTest#testDeleteFiles https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/7051 java.lang.NullPointerException at org.chromium.chrome.browser.widget.DateDividedAdapter$TimedItem.setPosition(DateDividedAdapter.java:64) at org.chromium.chrome.browser.widget.DateDividedAdapter$TimedItem.access$100(DateDividedAdapter.java:51) at org.chromium.chrome.browser.widget.DateDividedAdapter$ItemGroup.resetPosition(DateDividedAdapter.java:261) at org.chromium.chrome.browser.widget.DateDividedAdapter.setSizeAndGroupPositions(DateDividedAdapter.java:547) at org.chromium.chrome.browser.widget.DateDividedAdapter.addGroup(DateDividedAdapter.java:560) at org.chromium.chrome.browser.widget.DateDividedAdapter.setHeaders(DateDividedAdapter.java:587) at org.chromium.chrome.browser.download.ui.DownloadHistoryAdapter.filter(DownloadHistoryAdapter.java:650) at org.chromium.chrome.browser.download.ui.DownloadHistoryAdapter.onDownloadItemRemoved(DownloadHistoryAdapter.java:514) at org.chromium.chrome.browser.download.ui.StubbedProvider$StubbedDownloadDelegate$2.run(StubbedProvider.java:89) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5001) at java.lang.reflect.Method.invokeNative(Method.java) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) at dalvik.system.NativeStart.main(NativeStart.java) Adding back to the sheriff queue to track and possibly selectively disable failing tests.
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d4f6fdc1c619ac1e15ade577008de18525a132e commit 5d4f6fdc1c619ac1e15ade577008de18525a132e Author: Theresa <twellington@chromium.org> Date: Mon Jun 25 22:54:43 2018 Revert "Download location: enable flaky tests in DownloadActivityTest." This reverts commit ce3de2d33c08d47444e6f7798cea176654e642a5. Reason for revert: Some of the tests are still failing, triggering a try flakes alert. Will you please re-land with the tests we know are passing conditionally re-enabled? Original change's description: > Download location: enable flaky tests in DownloadActivityTest. > > The CL that causes the flakiness has been reverted. See: > https://chromium-review.googlesource.com/c/chromium/src/+/1112777 > Landed as e4144ed1a4845edb13e3afce024a8cb60588b38f. > > This CL enables flaky tests in DownloadActivityTest. > > TBR=dtrainor@chromium.org > > Bug: 855389,855219,855168,855167 > Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5 > Reviewed-on: https://chromium-review.googlesource.com/1113910 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570107} TBR=dtrainor@chromium.org,xingliu@chromium.org Change-Id: I7299f6a85b0acd59050f1f26c0f6c8a8fb3626c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855389, 855219, 855168, 855167 Reviewed-on: https://chromium-review.googlesource.com/1114044 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#570215} [modify] https://crrev.com/5d4f6fdc1c619ac1e15ade577008de18525a132e/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
,
Jun 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dgro...@chromium.org
, Jun 21 2018Owner: dtrainor@chromium.org
Status: Assigned (was: Untriaged)