See relevant discussion at [1] (visible by @google only). Repeating some parts from that discussion below. iron-icons.html dependency in Settings was added at [2]. This caused a 73kb size increase in the HTML bundles as follows: With iron-icons.html 218K Jun 21 12:02 lazy_load.vulcanized.html 266K Jun 21 12:02 vulcanized.html Without iron-iconts.html 145K Jun 21 12:19 lazy_load.vulcanized.html 266K Jun 21 12:19 vulcanized.html We should audit all other pages that do respect optimize_webui GN flag, for iron-icons.html usage. [1] https://groups.google.com/a/google.com/d/msg/chrome-settings/s-d70G9SIjk/cWJw-tFEBgAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/982159/13/chrome/browser/resources/settings/languages_page/languages_page.html
See relevant discussion at [1] (visible by @google only). Repeating some parts from that discussion below. iron-icons.html dependency in Settings was added at [2]. This caused a 73kb size increase in the HTML bundles as follows: With iron-icons.html 218K Jun 21 12:02 lazy_load.vulcanized.html 266K Jun 21 12:02 vulcanized.html Without iron-icons.html 145K Jun 21 12:19 lazy_load.vulcanized.html 266K Jun 21 12:19 vulcanized.html We should audit all other pages that do respect optimize_webui GN flag, for iron-icons.html usage. [1] https://groups.google.com/a/google.com/d/msg/chrome-settings/s-d70G9SIjk/cWJw-tFEBgAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/982159/13/chrome/browser/resources/settings/languages_page/languages_page.html
FYI, started looking into this for Settings. CL at https://chromium-review.googlesource.com/c/chromium/src/+/1121044.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af8dc0607079ea88d912e9f9a332ef2875e2179f commit af8dc0607079ea88d912e9f9a332ef2875e2179f Author: dpapad <dpapad@chromium.org> Date: Fri Jun 29 22:29:03 2018 WebUI Settings: Remove usage of iron-icons.html. Removing such dependency decreases the size of lazy_load_vulanized.html from 193kB to 120kB (measured on Linux). Moreover, the icon that was being used from iron-icons already exists in settings/icons.html. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieaac7925cb753f14f503404a63faf5d49bf5189a Reviewed-on: https://chromium-review.googlesource.com/1121044 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571681} [modify] https://crrev.com/af8dc0607079ea88d912e9f9a332ef2875e2179f/chrome/browser/resources/settings/languages_page/languages_page.html
started working to remove this from Extensions
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2099edb0bb5a89a130ae70b10579a906c48d342 commit d2099edb0bb5a89a130ae70b10579a906c48d342 Author: Scott Chen <scottchen@chromium.org> Date: Wed Jul 11 00:45:30 2018 Extensions: remove dependency on iron-icons By not including the entire svg sets from iron-icons/ the resulting md_extensions/vulcanized.html file size reduced from 232.8 kB to 144.4 kB. As a side clean-up thing, the "store" icon is removed from the icons.html since it's no longer used. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia19bd8b61425cbff0e3d70cc08a1201856fe0276 Reviewed-on: https://chromium-review.googlesource.com/1123164 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574005} [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/drop_overlay.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/icons.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/test/data/webui/extensions/extension_item_test.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/chrome/test/data/webui/settings/about_page_tests.js [modify] https://crrev.com/d2099edb0bb5a89a130ae70b10579a906c48d342/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c commit cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c Author: Alice Boxhall <aboxhall@chromium.org> Date: Wed Jul 11 04:05:30 2018 Revert "Extensions: remove dependency on iron-icons" This reverts commit d2099edb0bb5a89a130ae70b10579a906c48d342. Reason for revert: Seems to be causing test failures, e.g. https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941335040754288672%2F%2B%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrExtensionsItemsTest.DeveloperState%2F0 Original change's description: > Extensions: remove dependency on iron-icons > > By not including the entire svg sets from iron-icons/ the resulting > md_extensions/vulcanized.html file size reduced from 232.8 kB to > 144.4 kB. > > As a side clean-up thing, the "store" icon is removed from the icons.html > since it's no longer used. > > Bug: 855205 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Ia19bd8b61425cbff0e3d70cc08a1201856fe0276 > Reviewed-on: https://chromium-review.googlesource.com/1123164 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574005} TBR=dpapad@chromium.org,scottchen@chromium.org Change-Id: I8182c9d62e79688c8396852440e6367052fd08e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1132734 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#574068} [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/drop_overlay.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/icons.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/test/data/webui/extensions/extension_item_test.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/chrome/test/data/webui/settings/about_page_tests.js [modify] https://crrev.com/cc3ee735e343a2a3cf6a16cf9f7201eb3b6a759c/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9235ca8bfe3062c2397a3cb5ef107396adc6a01a commit 9235ca8bfe3062c2397a3cb5ef107396adc6a01a Author: Scott Chen <scottchen@chromium.org> Date: Thu Jul 12 00:33:44 2018 Reland "Extensions: remove dependency on iron-icons" Some files were depending on iron-icons/iron-icons.html to pull in iron-icon/iron-icon.html. Needed to add direct dependency to iron-icon.html, once iron-iconS.html was no longer imported. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icd95f6b178a40d7169611721deef38b04e291257 Reviewed-on: https://chromium-review.googlesource.com/1133588 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574430} [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/drop_overlay.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/icons.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/md_extensions/item.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/test/data/webui/extensions/extension_error_page_test.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/test/data/webui/extensions/extension_item_test.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/chrome/test/data/webui/settings/about_page_tests.js [modify] https://crrev.com/9235ca8bfe3062c2397a3cb5ef107396adc6a01a/ui/webui/resources/cr_elements/icons.html
This dependency had been removed from Settings and Extensions. We've decided to also remove it from everywhere so re-purposing this bug.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c01df8488508e1a2577a9ab6c28946a432dea6c commit 3c01df8488508e1a2577a9ab6c28946a432dea6c Author: Scott Chen <scottchen@chromium.org> Date: Mon Jul 16 21:49:54 2018 Sync Confirmation: remove iron-icons dependency. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id7c7ea9aa79c704c6971fe477a386f755261e822 Reviewed-on: https://chromium-review.googlesource.com/1135842 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#575439} [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/browser_resources.grd [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/people_page/people_page.js [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/people_page/sync_account_control.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/people_page/sync_account_control.js [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/site_settings/site_details_permission.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/settings/site_settings_page/site_settings_page.html [add] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/signin/dice_sync_confirmation/icons.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/chrome/test/data/webui/settings/sync_account_control_test.js [modify] https://crrev.com/3c01df8488508e1a2577a9ab6c28946a432dea6c/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56 commit 5675f5fcdff4d42edcd03f590bdf1c3b5a86db56 Author: Scott Chen <scottchen@chromium.org> Date: Wed Jul 18 18:40:50 2018 ChromeOS login: remove iron-icons dependency. This CL is part of the effort to remove usage of iron-icons/* iconsets to reduce size of resources loaded. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibc118f02603e735cc1f3adff66a4fb3fdaace2ce Reviewed-on: https://chromium-review.googlesource.com/1135990 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576148} [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/gaia_buttons.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/gaia_password_changed.css [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/gaia_password_changed.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/host-pairing-screen.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/navigation_bar.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/notification_card.css [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/notification_card.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/notification_card.js [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/offline_ad_login.css [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/chromeos/login/offline_ad_login.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/5675f5fcdff4d42edcd03f590bdf1c3b5a86db56/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1810be2240699e54da6fc861990afe7ab7184be commit b1810be2240699e54da6fc861990afe7ab7184be Author: Scott Chen <scottchen@chromium.org> Date: Wed Jul 18 22:13:03 2018 Media Router: remove iron-icons/ dependency Part of the effort to remove iron-icons/*.html iconsets from the repro. Screenshot showing icons unchanged from before: https://imgur.com/a/1iDQh03 Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac109e42bee49be6467e40746e3e54d4ab200826 Reviewed-on: https://chromium-review.googlesource.com/1139220 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576231} [modify] https://crrev.com/b1810be2240699e54da6fc861990afe7ab7184be/chrome/browser/resources/media_router/elements/route_controls/route_controls.html [modify] https://crrev.com/b1810be2240699e54da6fc861990afe7ab7184be/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e7b1029e2747adf714d30c1906259e60911c242 commit 5e7b1029e2747adf714d30c1906259e60911c242 Author: Scott Chen <scottchen@chromium.org> Date: Fri Jul 20 23:43:34 2018 WebUI: remove iron-icons/ dependency from inline_login. Bug: 855205 Change-Id: I96f9face7f052db192a8eb22077d5b1dd12da7ab Reviewed-on: https://chromium-review.googlesource.com/1144413 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577041} [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/browser/resources/inline_login/inline_login.html [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/browser/resources/inline_login/inline_login.js [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/browser/resources/media_router/icons/media_router_icons.html [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/chrome/test/data/webui/media_router/media_router_header_tests.js [modify] https://crrev.com/5e7b1029e2747adf714d30c1906259e60911c242/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6 commit 3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6 Author: Scott Chen <scottchen@chromium.org> Date: Mon Jul 23 22:13:35 2018 WebUI: fixes imports in assistant-optin UI. This CL changes imports from iron-icons.html to iron-icon.html (without S), as well as moving element imports to where it's used. Bug: 855205 Change-Id: Ibe22c21ec9270258efafd1e06fed73de1d226f2d Reviewed-on: https://chromium-review.googlesource.com/1145598 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577284} [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_optin.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.html [modify] https://crrev.com/3b6994b43ccad4f4ffcfcbe55b9177035c2c0ed6/chrome/browser/resources/chromeos/assistant_optin/setting_zippy.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45582fa80ea476f206b5aaae2e856f6448fa7764 commit 45582fa80ea476f206b5aaae2e856f6448fa7764 Author: Scott Chen <scottchen@chromium.org> Date: Tue Jul 24 18:05:50 2018 WebUI: Remove iron-icons from third_party/polymer. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I424db425db97b90c7374e9bc8c3504d1dbb32b01 Reviewed-on: https://chromium-review.googlesource.com/1147086 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577605} [modify] https://crrev.com/45582fa80ea476f206b5aaae2e856f6448fa7764/styleguide/web/web.md [modify] https://crrev.com/45582fa80ea476f206b5aaae2e856f6448fa7764/third_party/polymer/v1_0/bower.json [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/av-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/bower.json [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/communication-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/device-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/editor-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/hardware-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/image-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/iron-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/maps-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/notification-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/places-icons.html [delete] https://crrev.com/9c852c98761107a6be1069eb29beb6b9e4f60009/third_party/polymer/v1_0/components-chromium/iron-icons/social-icons.html [modify] https://crrev.com/45582fa80ea476f206b5aaae2e856f6448fa7764/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/45582fa80ea476f206b5aaae2e856f6448fa7764/ui/webui/resources/polymer_resources.grdp
Comment 1 by dpa...@chromium.org
, Jun 21 2018