New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855197 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 791396

Blocking:
issue 892001



Sign in to add a comment

Large zip file unzips incorrectly

Reported by nbis...@neverware.com, Jun 21 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Platform: 10575.54.0 (Official Build) beta-channel eve

Example URL:
https://davrt8itj6cgg.cloudfront.net/cloudready-free-66.3.16-64-bit/cloudready-free-66.3.16-64-bit.zip

Steps to reproduce the problem:
1. Download the zip file
2. Open the zip file in the Files app
3. Observe the size of the single file it contains (2.3 gb)

What is the expected behavior?
The file size should be closer to 6 gb.

What went wrong?
The file in the zip shows the wrong size, and if you copy the file out of the zip it is still the wrong size.

Did this work before? N/A 

Chrome version: 67.0.3396.78  Channel: beta
OS Version: 
Flash Version: 30.0.0.113
 

Comment 1 by mmenke@chromium.org, Jun 22 2018

Cc: yamaguchi@chromium.org yawano@chromium.org
Components: -Internals>Network Platform>Apps>FileManager
The file downloads and extracts correctly (Or at least the size is correct) on Windows, so I suspect this is a problem with the zip code, not the network code.

CCing owners of chrome/browser/resources/chromeos/zip_archiver/OWNERS, and adding the FileManager component though no idea if either of those will get this in front of the right people.

Comment 2 Deleted

I have confirmed this happens on the latest (69.0.3453.0) and M67 stable (67.0.3396.87).

As a workaround, set #enable-zip-archiver-unpacker flag to "Disabled" so that it'll read the content correctly.

So far I found that this doesn't happen when #enable-zip-archiver-unpacker flag is enabled. The flag config above rolls back the update that happened at M67 with Zip archiver. By this reason I think this is a regression at M67.

Comment 4 by dats@chromium.org, Jun 25 2018

Labels: CrOSFilesFeature-Zip
Status: Untriaged (was: Unconfirmed)
Cc: mtomasz@chromium.org nat...@solidstatenetworks.com
This is caused by not supporting ZIP64. (should read file size from extra field when needed.)
I quickly took a look and seems minizip supports ZIP64 since version 2.3.0.
https://github.com/nmoinvaz/minizip/commit/a56a08cf793f943d309367be9289eae7844b0754
Zip Archiver is based on minizip version 1.2.
Blocking: 821761
This issue is a blocker for  Issue 821761  because the workaround mentioned in #3 will become unavailable after removing the old extension.


Owner: weifangsun@chromium.org
Assigning to weifangsun@ for triage.
Thanks for looping me in yamaguchi@. Can you confirm - the fix for this issue is to update the minizip library referenced by the Zip Archiver? What is the level of effort/impact of doing this?
Labels: M-69
Labels: -M-69 M-71
Cc: weifangsun@chromium.org
Owner: ----
Status: Available (was: Untriaged)
Owner: amistry@chromium.org
Status: Assigned (was: Available)
Blockedon: 791396
Labels: -M-71 M-72
Blocking: 892001
Blocking: -821761
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e

commit 21ce588d37c189646cd80e46c7ea1ddd5ec0f98e
Author: Anand K. Mistry <amistry@chromium.org>
Date: Mon Nov 05 07:06:07 2018

Uprev minizip to 2.7.0

BUG= 791396 , 855197 

Change-Id: I4e4602e3748247c6bd0d1973c368467e1dc057fc
Reviewed-on: https://chromium-review.googlesource.com/c/1309387
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605270}
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/DEPS
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/BUILD.gn
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/compressor_archive_minizip_unittest.cc
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/minizip_helpers.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip.h
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive_minizip_unittest.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_reader_javascript_stream.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/BUILD.gn
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/minizip_compress_fuzzer.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/testing/libfuzzer/fuzzers/minizip_uncompress_fuzzer.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/BUILD.gn
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/DEPS
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/README.chromium
[add] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/third_party/minizip/mz_os_chrome.cc
[modify] https://crrev.com/21ce588d37c189646cd80e46c7ea1ddd5ec0f98e/ui/file_manager/integration_tests/file_manager/zip_files.js

Status: Fixed (was: Assigned)

Sign in to add a comment